Page MenuHome
Differential D6918

Fix T74110: EEVEE Shadow Pass
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Feb 24 2020, 10:48 AM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T74110: EEVEE: Shadow Pass Visible on Backsided geometry
Commits
rB403bb357ae2b: Fix T74110: EEVEE Shadow Pass
Summary

Shadow could penetrate occluded geometry. This patch adds a check to see
if the light is in the right location to light the pixel.

Diff Detail

Repository
rB Blender
Branch
T74110 (branched from master)
Build Status
Buildable 6736
Build 6736: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Feb 24 2020, 10:48 AM
Harbormaster completed remote builds in B6735: Diff 21991.Feb 24 2020, 10:48 AM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Feb 24 2020, 10:50 AM
Jeroen Bakker (jbakker) added a project: GPU / Viewport.
Jeroen Bakker (jbakker) updated this revision to Diff 21992.Feb 24 2020, 11:04 AM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Missed file in previous commit
don't light background just like Cycles does.

Harbormaster completed remote builds in B6736: Diff 21992.Feb 24 2020, 11:04 AM
Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Feb 24 2020, 11:05 AM
Clément Foucault (fclem) added inline comments.Feb 24 2020, 11:15 AM
source/blender/draw/engines/eevee/shaders/shadow_accum_frag.glsl
52

does cycles actually have this fallof? if not just use a step function.

Jeroen Bakker (jbakker) updated this revision to Diff 21999.Feb 24 2020, 1:16 PM

Better matching with Cycles

Harbormaster completed remote builds in B6739: Diff 21999.Feb 24 2020, 1:17 PM
Clément Foucault (fclem) added inline comments.Feb 24 2020, 1:36 PM
source/blender/draw/engines/eevee/shaders/shadow_accum_frag.glsl
52

l_vector is not normalized. so i'm guessing the 1.5 factors are not correct.

Jeroen Bakker (jbakker) updated this revision to Diff 22114.Feb 27 2020, 9:20 AM

Normalized the light_vector

Harbormaster completed remote builds in B6803: Diff 22114.Feb 27 2020, 9:20 AM
Clément Foucault (fclem) accepted this revision.Feb 27 2020, 3:15 PM
This revision is now accepted and ready to land.Feb 27 2020, 3:15 PM
Jeroen Bakker (jbakker) marked 2 inline comments as done.Feb 27 2020, 3:53 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/draw/engines/eevee/shaders/shadow_accum_frag.glsl
52

Best result I got with

float light_input = smoothstep(1.5, -1.5, -dot(N, l_vector.xyz));

But it will leave artifacts near edges.

Closed by commit rB403bb357ae2b: Fix T74110: EEVEE Shadow Pass (authored by Jeroen Bakker (jbakker)). · Explain WhyFeb 27 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB403bb357ae2b: Fix T74110: EEVEE Shadow Pass.
Jeroen Bakker (jbakker) added a reverting change: rB40343a76c56f: Revert "Fix T74110: EEVEE Shadow Pass".Mar 3 2020, 12:36 PM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
eevee/
shaders/
6 lines
intern/
shaders/
1 line

Diff 21992

View Options

source/blender/draw/engines/eevee/shaders/shadow_accum_frag.glsl

Loading...
View Options

source/blender/draw/intern/shaders/common_view_lib.glsl

Loading...