Page MenuHome

Fix T74119: Cycles Viewport Render Tint
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Feb 24 2020, 1:59 PM.

Details

Summary

Cycles uses the display_space_shader it gets from Blender. When
requested the shader used to be a GPU_SHADER_2D_IMAGE_COLOR, which
set the color uniform incorrectly. This resulted in a yellowish tint
when used.

There are two valid solutions.

  1. Set the uniform correctly (vec4 vs vec3)
  2. Use GPU_SHADER_2D_IMAGE shader as the color variant is not used.

For this fix I selected to use the GPU_SHADER_2D_IMAGE shader. Not
sure if other render engine uses the color mask.

Diff Detail

Repository
rB Blender

Event Timeline

This revision is now accepted and ready to land.Feb 24 2020, 3:31 PM
This revision was automatically updated to reflect the committed changes.