Page MenuHome
Differential D6932

Shading: Add invert option to Vector Rotate Node
ClosedPublic
Actions

Authored by Charlie Jolly (charlie) on Feb 25 2020, 3:53 PM.

Details

Reviewers
Simon Thommes (simonthommes)
Brecht Van Lommel (brecht)
Commits
rCdbefd1e84dce: Shading: Add invert option to Vector Rotate Node
rB847c091ae838: Shading: Add invert option to Vector Rotate Node
Summary

Checkbox to invert rotation angle, suggested by @Simon Thommes (simonthommes)

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 6764
Build 6764: arc lint + arc unit

Event Timeline

Charlie Jolly (charlie) created this revision.Feb 25 2020, 3:53 PM
Harbormaster completed remote builds in B6764: Diff 22045.Feb 25 2020, 3:53 PM
Charlie Jolly (charlie) mentioned this in T72337: Shader Node Additions.Feb 25 2020, 3:59 PM
Charlie Jolly (charlie) added a reviewer: Brecht Van Lommel (brecht).Feb 25 2020, 5:19 PM
Simon Thommes (simonthommes) accepted this revision.Feb 25 2020, 5:36 PM

Patch works as intended for me.
Usecase:
-intuitive and easy way of inverting an euler rotation with the same rotation vector (rotating back and forth)
-replicating the 'Texture' rotation type from the mapping node
-much less cluttered rotation type dropdown menu by dropping

This revision is now accepted and ready to land.Feb 25 2020, 5:36 PM
huajian qiu (wakin) added a subscriber: huajian qiu (wakin).Feb 25 2020, 9:40 PM
huajian qiu (wakin) removed a subscriber: huajian qiu (wakin).
huajian qiu (wakin) added a subscriber: huajian qiu (wakin).
Brecht Van Lommel (brecht) accepted this revision.Feb 28 2020, 2:50 PM
Brecht Van Lommel (brecht) added inline comments.
intern/cycles/kernel/shaders/node_vector_rotate.osl
30

Use (invert) ? , any non-zero values should be interpreted as true.

Closed by commit rB847c091ae838: Shading: Add invert option to Vector Rotate Node (authored by Charlie Jolly (charlie)). · Explain WhyMar 2 2020, 1:57 PM
This revision was automatically updated to reflect the committed changes.
Charlie Jolly (charlie) marked an inline comment as done.
Charlie Jolly (charlie) added a commit: rB847c091ae838: Shading: Add invert option to Vector Rotate Node.
Brecht Van Lommel (brecht) added a commit: rCdbefd1e84dce: Shading: Add invert option to Vector Rotate Node.Jun 2 2020, 7:39 AM

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
1 line
kernel/
shaders/
34 lines
svm/
67 lines
render/
1 line
19 lines
source/
blender/
editors/
space_node/
1 line
gpu/
shaders/
material/
21 lines
makesrna/
intern/
11 lines
nodes/
shader/
nodes/
3 lines

Diff 22045

View Options

intern/cycles/blender/blender_shader.cpp

Loading...
View Options

intern/cycles/kernel/shaders/node_vector_rotate.osl

Loading...
View Options

intern/cycles/kernel/svm/svm_vector_rotate.h

Loading...
View Options

intern/cycles/render/nodes.h

Loading...
View Options

intern/cycles/render/nodes.cpp

Loading...
View Options

source/blender/editors/space_node/drawnode.c

Loading...
View Options

source/blender/gpu/shaders/material/gpu_shader_material_vector_rotate.glsl

Loading...
View Options

source/blender/makesrna/intern/rna_nodetree.c

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_vector_rotate.c

Loading...