Page MenuHome

Fix T74228: Strange Characters
AbandonedPublic

Authored by Germano Cavalcante (mano-wii) on Feb 26 2020, 1:19 PM.

Details

Summary

I'm not sure but the GPU_texture_update_sub behavior seems
to vary on some GPUs.

So here's a safer solution.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 6776
Build 6776: arc lint + arc unit

Event Timeline

If you disable GPU_texture_update_sub when there is more than one row, then you're effectively disabling it entirely? Since I guess you usually need more than one row.

It's usually just one row.
Multiple rows only appear when typing many different characters or maximizing the scale of the text.

Ok, but then I do wonder if this will actually solve T74228: strange characters? Since I see no indication that is a case where it would need multiple rows.

Ok, but then I do wonder if this will actually solve T74228: strange characters? Since I see no indication that is a case where it would need multiple rows.

There some characters are working and others are not.
Those that are not working seem to be the result of a poor alignment of the buffer within the texture (reading characters in the wrong position and with different size).
It is possible that the problem is in the shader, but it is more likely to be in the part indicated here.

Brecht Van Lommel (brecht) accepted this revision.EditedFeb 27 2020, 2:34 PM

Let's try and see if it solves the issue. If it doesn't we can always revert.

This revision is now accepted and ready to land.Feb 27 2020, 2:34 PM