Paths

Table of Contentst

Differential D6944

Skip EditMesh to Mesh Conversion
AbandonedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Feb 26 2020, 7:03 PM.

Tags

None

Subscribers

Brecht Van Lommel (brecht)

Tokens

"Love" token, awarded by billreynish."100" token, awarded by Frozen_Death_Knight."Like" token, awarded by Dangry."Like" token, awarded by TheRedWaxPolice."Love" token, awarded by ace_dragon.

Details

Reviewers

Clément Foucault (fclem)
Campbell Barton (campbellbarton)

Group Reviewers

Summary

(Part of T73360)
This is kind of a conceptual project, probably needs more testing,
The idea is lazily initialize the edit-mesh to mesh conversion.

In my tests this resulted in an improvement from 2.9 fps to 4.0 fps
(66% of the speed seen in 2.79).

It is certainly one of the ways to go.

Diff Detail

Repository

Branch

arcpatch-D6944 (branched from master)

Build Status

Buildable 6795
Build 6795: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Feb 26 2020, 7:03 PM

Harbormaster completed remote builds in B6789: Diff 22097.Feb 26 2020, 7:03 PM

Adam Friesen (ace_dragon) awarded a token.Feb 26 2020, 7:09 PM

TheRedWaxPolice (TheRedWaxPolice) awarded a token.Feb 26 2020, 7:16 PM

Daniel Gryningstjerna (Dangry) awarded a token.Feb 26 2020, 9:07 PM

Warnings and fixes

Harbormaster completed remote builds in B6795: Diff 22103.Feb 26 2020, 9:10 PM

Fix: test use_editmesh_eval in cage

Harbormaster completed remote builds in B6797: Diff 22105.Feb 26 2020, 9:20 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Feb 26 2020, 11:06 PM

William Reynish (billreynish) awarded a token.Feb 26 2020, 11:22 PM

I think for this to be easy to understand, we should have a few accessor functions to get the evaluated mesh, editmesh, cage, etc. And never access it directly.

Carefully naming and commenting these functions is important, and may require some code refactoring. There are a lot of object/mesh blenkernel API functions, and it's often hard to tell which ones to use for which purpose.

Same feeling as @Brecht Van Lommel (brecht). Having accessor function to avoid repetition is needed.

source/blender/draw/engines/overlay/overlay_wireframe.c
187	This should really be its own function.

This revision now requires changes to proceed.Mar 26 2020, 12:53 AM

This patch is more of a proof of concept.
There's another one being worked on in more depth (D7169: Bypass EditMesh to Mesh conversion (initial step)).

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

BKE_DerivedMesh.h

4 lines

10 lines

intern/

18 lines

data_transfer.c

2 lines

13 lines

32 lines

2 lines

10 lines

draw/

engines/

overlay/

overlay_edit_mesh.c

12 lines

overlay_wireframe.c

11 lines

intern/

draw_cache_extract.h

1 line

draw_cache_extract_mesh.c

47 lines

draw_cache_impl_mesh.c

25 lines

editors/

transform/

transform_snap_object.c

23 lines

uvedit/

9 lines

modifiers/

intern/

6 lines

2 lines

MOD_meshdeform.c

3 lines

MOD_surfacedeform.c

2 lines

MOD_weightvgproximity.c

3 lines

Diff 22103

source/blender/blenkernel/BKE_DerivedMesh.h

Loading...

source/blender/blenkernel/BKE_modifier.h

Loading...

source/blender/blenkernel/intern/DerivedMesh.c

Loading...

source/blender/blenkernel/intern/data_transfer.c

Loading...

source/blender/blenkernel/intern/mesh_convert.c

Loading...

source/blender/blenkernel/intern/modifier.c

Loading...

source/blender/blenkernel/intern/object.c

Loading...

source/blender/blenkernel/intern/shrinkwrap.c

Loading...

source/blender/draw/engines/overlay/overlay_edit_mesh.c

Loading...

source/blender/draw/engines/overlay/overlay_wireframe.c

Loading...

source/blender/draw/intern/draw_cache_extract.h

Loading...

source/blender/draw/intern/draw_cache_extract_mesh.c

Loading...

source/blender/draw/intern/draw_cache_impl_mesh.c

Loading...

source/blender/editors/transform/transform_snap_object.c

Loading...

source/blender/editors/uvedit/uvedit_draw.c

Loading...

source/blender/modifiers/intern/MOD_array.c

Loading...

source/blender/modifiers/intern/MOD_boolean.c

Loading...

source/blender/modifiers/intern/MOD_meshdeform.c

Loading...

source/blender/modifiers/intern/MOD_surfacedeform.c

Loading...

source/blender/modifiers/intern/MOD_weightvgproximity.c

Loading...