Fix T74320: sound strip waveforms drawing allows negative volume values
ClosedPublic
Actions

Authored by Alessio Monti di Sopra (a.monti) on Feb 29 2020, 10:15 PM.

Details

Reviewers

Richard Antalik (ISS)
Brecht Van Lommel (brecht)

Maniphest Tasks

T74320: Video Sequencer: Waveform drawing needs to be clamped for negative values.

Commits

rBe9e4f6af9e79: Fix T74320: Sound strip waveforms drawing allows negative volume values

Summary

While animating sound strips volume within the graph editor, it is possible to set keyframes to negative values.
The drawing code of waveforms wasn't clamping these values to zero and was instead drawing an "inverted" curve.

Diff Detail

Repository: rB Blender

Event Timeline

Alessio Monti di Sopra (a.monti) created this revision.Feb 29 2020, 10:15 PM

Alessio Monti di Sopra (a.monti) added a task: T74320: Video Sequencer: Waveform drawing needs to be clamped for negative values..

Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Feb 29 2020, 10:33 PM

Peter Fog (tintwotin) awarded a token.Feb 29 2020, 10:35 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 1 2020, 3:45 PM

This revision is now accepted and ready to land.Mar 1 2020, 3:45 PM

Richard Antalik (ISS) accepted this revision.Mar 2 2020, 2:48 AM

Closed by commit rBe9e4f6af9e79: Fix T74320: Sound strip waveforms drawing allows negative volume values (authored by Richard Antalik (ISS)). · Explain WhyMar 2 2020, 2:52 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rBe9e4f6af9e79: Fix T74320: Sound strip waveforms drawing allows negative volume values.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_sequencer/

sequencer_draw.c

1 line

Diff 22234

View Options

source/blender/editors/space_sequencer/sequencer_draw.c

Fix T74320: sound strip waveforms drawing allows negative volume valuesClosedPublicActions