Added specific clamping functions to vectors, so that calling CLAMP for each element can be avoided.
Created a GTest file for math_vector.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Generally seems fine, one request inline.
Edit, I don't have a strong opinion on this one if others prefer longer name, personally it doesn't seem necessary.
| source/blender/blenlib/intern/math_vector.c | ||
|---|---|---|
| 1054–1073 | I think it's reasonable to make the _flfl implicit. as clamp_v2(vec, min, max) is quite clear. clamp_v2_v2v2 could be kept since I think this more of an exception. | |
| source/blender/blenlib/intern/math_vector.c | ||
|---|---|---|
| 1054–1073 | Indeed, and since it's probably the most common case I think it'll be better to make it shorter. | |