Page MenuHome

Fix T74331: Updated "View Selected" in preferences->keymap to "Frame Selected"
AbandonedPublic

Authored by Asad-ullah Khan (kh4n) on Mar 1 2020, 7:34 AM.

Details

Summary

Fix T74331

) In the View menu the action is now called "Frame Selected",
but in Preferences > Keymap, the action is still called
"View Selected". This means when you go to search for the
action to edit its hotkey, it can't be found.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 6850
Build 6850: arc lint + arc unit

Event Timeline

Ankit Meel (ankitm) retitled this revision from T74331: Updated "View Selected" in preferences->keymap to "Frame Selected" to Fix T74331: Updated "View Selected" in preferences->keymap to "Frame Selected".Mar 1 2020, 7:41 AM
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)
Brecht Van Lommel (brecht) requested changes to this revision.Mar 1 2020, 3:43 PM

There are more View Selected operators in other editors. If we make this kind of change, it should be done everywhere.

This revision now requires changes to proceed.Mar 1 2020, 3:43 PM

There are other "View Selected" instances, but none of them have the same description as this one. Should I still change them? Or is there somewhere else I should look? Currently, I am only looking for/modifying ot->name fields

@Asad-ullah Khan (kh4n) Yes, go through all the editors and change all to have the same name. Thanks!

I have gone ahead and changed the ones I've found, but before I submit the diff, I was wondering (since this also makes all the callback names wrong too) why not just change the "Frame Selected" in the action menu back to "View Selected"? Especially since some of the other menus have "View <something>" operators as well?

There was a decision to change the name from View Selected to Frame Selected, since this is a more standard (and descriptive) name.

Asad-ullah Khan (kh4n) updated this revision to Diff 22288.EditedMar 2 2020, 10:08 PM

Now all "View Selected" instances have been changed

@Brecht Van Lommel (brecht) I changed it where I could find, let me know if anything else needs to be done