Page MenuHome

Fix: Library dependencies being build and checked every time you build a subproject
ClosedPublic

Authored by Ray Molenkamp (LazyDodo) on Mar 1 2020, 10:56 PM.

Details

Summary

Previously blenders library dependencies where passed as interface targets (ie: people that link me need to link to this, but I don't need it myself to build)

rB517870a4a11f660c71d3901818fbb09798cb2d7d broke this by removing the interface linkage meaning all deps now have the public linkage on them which means, I'm gonna to link it, so you better check that it is build before you attempt to build me.

Which results in if you check out blender and try to build just bf_editor_sculpt_paint cause someone is complaining about a build error you get to sit around for 15-20 minutes while cycles and blenkernel,blenlib and 10's of other libs build, not OK.

And even if you wait that 20 minutes for it to build , you make a code change, it still checks all the depended projects for changes before going to build bf_editor_sculpt_paint making a 1 line change build take 30-60 seconds, not OK.

Diff Detail

Repository
rB Blender

Event Timeline

Did you test this on Linux buildbot to make sure this doesn't break workaround for TBB/MKL? (if it does break one of tests will fail).

I can confirm that this works on my system which had the TBB issue. And that removing the TBB workaround still fails the tests, to be sure I'm really testing it on a system that has the problem.

This revision is now accepted and ready to land.Mar 2 2020, 11:09 AM

Nice, thanks Brecht for test and Ray for fix.

This revision was automatically updated to reflect the committed changes.