Update matcaps to include specular pass.
Needs RevisionPublic
Actions

Authored by Jean Da Costa (jeacom256) on Mar 2 2020, 2:15 AM.

Details

Reviewers

Pablo Dobarro (pablodp606)
Clément Foucault (fclem)
Jeroen Bakker (jbakker)

Summary

Since D5335 blender has support for a separate specular pass but matcaps were made prior to this patch and cant make use of this feature.

I took the liberty to remaster those matcaps and split the specular from the diffuse pass, most matcaps should be indistinguishable from the original when combined except for ceramic_lightbulb.exr which got some slight improvements.

contrast should be improved when random colors is enabled.

jade.exr(new)
Specular enabled

jade.exr(new)
Specular disabled

old

new

Diff Detail

Repository: rB Blender

Event Timeline

Jean Da Costa (jeacom256) created this revision.Mar 2 2020, 2:15 AM

Buddy, Whatever you do, please don’t touch the “basic_2” matcap, unless you're the original author, which I think you aren't?
Not all matcaps need this treatment.

It'd be wise not to touch other people matcaps. 😉

I think there needs to be a settting that can blend the specular pass with the diffuse pass so the user can control the amount of specular highlight.

@Regnas (Regnas) I was concerned this could seem somewhat wrong for some people even me. But remember, all those matcaps are in public domain

Moreover, I was specially careful to not alter the underlying artistic information in the image, when you add the diffuse and specular layers, the result is identical to the original, except for the lightbulb one (Which I am the author of).

Maybe you want to verify the matcap wasnt changed yourself.

basic_2.exr132 KBDownload

@TheRedWaxPolice (TheRedWaxPolice), you are the author right? Is ok for you?

Jean Da Costa (jeacom256) added a subscriber: TheRedWaxPolice (TheRedWaxPolice).Mar 2 2020, 3:33 AM

In D6985#166115, @Aaron Carlisle (Blendify) wrote:

I think there needs to be a settting that can blend the specular pass with the diffuse pass so the user can control the amount of specular highlight.

Yeah, I think this is a good idea.

In D6985#166113, @Regnas (Regnas) wrote:

Buddy, Whatever you do, please don’t touch the “basic_2” matcap, unless you're the original author, which I think you aren't?
Not all matcaps need this treatment.

It'd be wise not to touch other people matcaps. 😉

This is not Blender development policy at all. It is encouraged to improve work regardless of who the original author is, but just like any contribution it needs to be carefully reviewed.

In D6985#166182, @Brecht Van Lommel (brecht) wrote:

This is not Blender development policy at all. It is encouraged to improve work regardless of who the original author is, but just like any contribution it needs to be carefully reviewed.

Ok then.
I already made a backup, so I should be fine, I guess.

Fran Marz (franMarz) awarded a token.Mar 3 2020, 8:21 AM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Apr 13 2020, 7:29 PM

Is there anything holding this patch back? or a reason to postpone it?

William Reynish (billreynish) edited reviewers, added: Clément Foucault (fclem); removed: William Reynish (billreynish).Apr 15 2020, 1:10 PM

Brecht Van Lommel (brecht) added a reviewer: Jeroen Bakker (jbakker).Apr 15 2020, 1:45 PM

It seems like this patch is broken. I cannot read the exr files.

This revision now requires changes to proceed.Sep 17 2020, 12:40 PM

RedMser (RedMser) added a subscriber: RedMser (RedMser).Oct 11 2020, 2:00 PM