Fix T68629: EXCEPTION_ACCESS_VIOLATION when entering Edit Mode
Needs ReviewPublic
Actions

Authored by Deep Majumder (dmcoder) on Mar 2 2020, 7:27 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T68629: EXCEPTION_ACCESS_VIOLATION when entering Edit Mode

Summary

Fix T68629
A null pointer check added

Diff Detail

Repository

rB Blender

Branch

mesh-conv-bug (branched from master)

Build Status

Buildable 6888
Build 6888: arc lint + arc unit

Event Timeline

Deep Majumder (dmcoder) created this revision.Mar 2 2020, 7:27 PM

Harbormaster completed remote builds in B6888: Diff 22282.Mar 2 2020, 7:27 PM

Deep Majumder (dmcoder) retitled this revision from Gitignore modified to A fix for T68629.Mar 2 2020, 7:29 PM

Deep Majumder (dmcoder) added a reviewer: Ankit Meel (ankitm).

Deep Majumder (dmcoder) changed the edit policy from "All Users" to "Administrators".

Deep Majumder (dmcoder) changed the edit policy from "Administrators" to "All Users".Mar 2 2020, 7:45 PM

the first some lines in gitignore specify . files. so vscode line is not needed.
I am not really qualified for being a reviewer.. you should necessarily add someone with commit access. pick people from here: https://wiki.blender.org/wiki/Modules
reading from @Bastien Montagne (mont29) 's comment

Crash happens in CustomData_to_bmesh_block() while trying to copy a CD_FACEMAP layer which source's CustomDataLayer has a NULL data pointer... I'd say NULL pointer here should never happen? Code is not expecting such thing in any case.

so I think, preventing the src_data from being NULL should be a nicer fix, though take it with a grain of salt. I have no idea of the code here.
(I added reviewers based on past assignees)

This revision now requires changes to proceed.Mar 2 2020, 7:47 PM

How do I get of the .gitignore change? I did not mean it do be here..

git diff source/blender/blenkernel/intern/customdata.c

removed gitignore

Harbormaster completed remote builds in B6889: Diff 22284.Mar 2 2020, 8:07 PM

Ankit Meel (ankitm) retitled this revision from A fix for T68629 to Fix T68629: EXCEPTION_ACCESS_VIOLATION when entering Edit Mode.Mar 2 2020, 8:08 PM

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

Ankit Meel (ankitm) removed a reviewer: Ankit Meel (ankitm).

Ankit Meel (ankitm) added a task: T68629: EXCEPTION_ACCESS_VIOLATION when entering Edit Mode.

In D6993#166437, @Deep Majumder (dmcoder) wrote:

How do I get of the .gitignore change? I did not mean it do be here..

Just a tip: next time you want to ignore files that are specific to your setup, edit .git/info/exclude instead. That file works the same as .gitignore, but isn't part of Blender's sources, so there is no chance that you accidentally share your changes.

Bastien Montagne (mont29) removed a reviewer: Bastien Montagne (mont29).Mon, Jan 23, 4:09 PM

Bastien Montagne (mont29) added projects: BF Blender, Modeling.

Bastien Montagne (mont29) removed a subscriber: Bastien Montagne (mont29).