Page MenuHome
Differential D6997

Fix T74377: Weld Modifier destroys vertex groups
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Mar 2 2020, 10:33 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Group Reviewers
Modifiers
Maniphest Tasks
T74377: Two weld modifiers work different together and serial/separately
Commits
rB5a77748e470d: Fix T74377: Weld Modifier destroys vertex groups
Summary

BKE_mesh_new_nomain_from_template does not add a custom data of type CD_MDEFORMVERT, so it is not copied from the original mesh to the resulting mesh.
Studying the code, I realized that by default the meshes have this customdata set not to be copied.
But the requiredDataMask callback seems to be a workaround for this.

Ref T74377

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 6891
Build 6891: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Mar 2 2020, 10:33 PM
Harbormaster completed remote builds in B6891: Diff 22289.Mar 2 2020, 10:33 PM
Brecht Van Lommel (brecht) accepted this revision.Mar 2 2020, 10:36 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

This is the correct solution, we only copy required attributes for memory usage and performance reasons.

This revision is now accepted and ready to land.Mar 2 2020, 10:36 PM
Closed by commit rB5a77748e470d: Fix T74377: Weld Modifier destroys vertex groups (authored by Germano Cavalcante (mano-wii)). · Explain WhyMar 2 2020, 10:48 PM
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB5a77748e470d: Fix T74377: Weld Modifier destroys vertex groups.

Revision Contents
Changeset List

PathSize
source/
blender/
modifiers/
intern/
14 lines

Diff 22289

View Options

source/blender/modifiers/intern/MOD_weld.c

Loading...