Page MenuHome
Differential D7005

Fix T74392: HDRI preview spheres appear in render passes and reflections
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 3 2020, 10:04 AM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T74392: HDRI Preview Spheres appear in Viewport render passes
T74212: HDRI Preview Spheres appear in surface reflections
Commits
rB456595fd39c2: Fix T74392: HDRI preview spheres appear in render passes and reflections
Summary

Do not render HDRI Previews when a renderpass is active

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 3 2020, 10:04 AM
Harbormaster completed remote builds in B6909: Diff 22315.Mar 3 2020, 10:04 AM
Evan Wilson (EAW) added a task: T74392: HDRI Preview Spheres appear in Viewport render passes.Mar 3 2020, 10:59 AM
Brecht Van Lommel (brecht) retitled this revision from EEVEE: Render Passes to Fix T74392: HDRI preview spheres appear in render passes and reflections.Mar 5 2020, 11:56 AM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

@Jeroen Bakker (jbakker), please follow commit message guidelines for subject lines for commits and code reviews.
https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

The subject line should not contain only the category, but a brief description of what the commit does.

Clément Foucault (fclem) accepted this revision.Mar 5 2020, 12:14 PM
This revision is now accepted and ready to land.Mar 5 2020, 12:14 PM
Closed by commit rB456595fd39c2: Fix T74392: HDRI preview spheres appear in render passes and reflections (authored by Jeroen Bakker (jbakker)). · Explain WhyMar 12 2020, 9:28 AM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB456595fd39c2: Fix T74392: HDRI preview spheres appear in render passes and reflections.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
4 lines
source/
blender/
draw/
engines/
eevee/
4 lines
2 lines
18 lines

Diff 22712

View Options

release/scripts/startup/bl_ui/space_view3d.py

Loading...
View Options

source/blender/draw/engines/eevee/eevee_lookdev.c

Loading...
View Options

source/blender/draw/engines/eevee/eevee_materials.c

Loading...
View Options

source/blender/draw/engines/eevee/eevee_private.h

Loading...