Page MenuHome
Differential D700

Remove Simple Shader
AbandonedPublic
Actions

Authored by Jason Wilkins (jwilkins) on Aug 2 2014, 2:43 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Antonis Ryakiotakis (psy-fi)
Summary

The simple shader is dead code (unused by Blender) and will be replaced by code based on it in Viewport FX.

Diff Detail

Event Timeline

Jason Wilkins (jwilkins) updated this revision to Diff 2298.Aug 2 2014, 2:43 PM
Jason Wilkins (jwilkins) retitled this revision from to Remove Simple Shader.
Jason Wilkins (jwilkins) updated this object.
Jason Wilkins (jwilkins) added reviewers: Campbell Barton (campbellbarton), Sergey Sharybin (sergey), Antonis Ryakiotakis (psy-fi).
Antonis Ryakiotakis (psy-fi) edited edge metadata.Aug 7 2014, 1:00 PM

I'd rather not remove this yet if it's not conflicting with real functionality you will be committing for review. It should be removed when the replacement code is ready.

Sergey Sharybin (sergey) edited edge metadata.Sep 5 2014, 9:53 AM

I'm not so much fussed here, but currently viewport is being lead by @Antonis Ryakiotakis (psy-fi), so leaving final decision to him.

Antonis Ryakiotakis (psy-fi) added a comment.Sep 5 2014, 10:39 AM

Yep, leave it for now.

Jason Wilkins (jwilkins) added a comment.Sep 10 2014, 2:32 AM

I added this now because it doesn't really have any dependencies. Doesn't really matter when it is done, but it is part of viewport.

Jeff LaMarche (jlamarche) mentioned this in T42133: 2.72 Launch on Crash on Mac Pro 2014.Oct 7 2014, 4:33 PM
Thomas Dinges (dingto) mentioned this in T40725: MacPro model late 2013 problems with Blender.Oct 12 2014, 3:50 PM
Sergey Sharybin (sergey) requested changes to this revision.Dec 3 2014, 6:40 PM
Sergey Sharybin (sergey) edited edge metadata.

I'd just leave it alone and remove in the branch if it's not really needed.

This revision now requires changes to proceed.Dec 3 2014, 6:40 PM
Jason Wilkins (jwilkins) added a comment.EditedDec 3 2014, 6:44 PM

@Sergey Sharybin (sergey) ok, I'll just fold this in with the combined patch I'm currently working on

John Cox (johnedwardcox) mentioned this in T44674: Split OpenCL Kernel fails to compile on Mac Pro.May 11 2015, 6:38 PM
André Franco (andreh) mentioned this in T46485: Dopesheet - Arrange Layers.Oct 14 2015, 6:38 PM
rafek yousef (rafek_finearts) mentioned this in T47458: Network render plugin.Feb 17 2016, 2:52 PM
Rob-ART Morgan (barefeats) mentioned this in T48972: OpenCL build failure with NVIDIA GeForce GTX 980 Ti GPU.Jul 29 2016, 6:08 PM
Campbell Barton (campbellbarton) removed a reviewer: Campbell Barton (campbellbarton).Aug 11 2016, 6:24 AM
Mike Erwin (merwin) abandoned this revision.Sep 21 2016, 6:44 PM
Christian Jara (cjcutter2) mentioned this in T49535: Crashes on Cycles GPU Compute with OpenCL.Oct 2 2016, 7:30 PM
Shunsuke Saito (shunke) mentioned this in T50250: < Weight Painting > Show Zero Wights - Active does not work..Dec 14 2016, 3:01 PM
Philip Watkin (dolphinstudios) mentioned this in T50788: Blender Crash on Startup OS10.12 Mac Pro.Feb 26 2017, 6:05 PM
Eric Lafarge (EricLafarge) mentioned this in T51682: Failed loading render kernel.May 31 2017, 5:50 PM
Thomas E Frede (ThomasFrede) mentioned this in T51988: The 3D cursor is stuck and cannot be placed with the RMB in the object mode. It works in the editing mode. .Jul 7 2017, 9:03 AM
Sergey Sharybin (sergey) mentioned this in T52395: Render time more than doubled on Mac since last release.Aug 14 2017, 2:29 PM
Fred Sprinkle (fsprinkle) mentioned this in T52412: Right-click select broken in 3D view - Mac OS / 2.79.Aug 16 2017, 1:19 AM
André Franco (andreh) mentioned this in T52495: BLENDER 2.79 RC2 - DENOISE NOT WORKING ON MACPRO OSX EL CAPITAIN.Aug 22 2017, 3:37 PM
Mace (Mace2055) mentioned this in T52740: AMD GPU firepro D700 not valid compute device in 2.79.Sep 14 2017, 3:15 AM
florian mosleh (flowb) mentioned this in T52876: 2.79 macOS Material Preview is broken.Sep 22 2017, 7:26 PM
pier shaw (piershaw) mentioned this in T53858: Cycles Crash when changing Transparency.Jan 22 2018, 11:00 PM
pier shaw (piershaw) mentioned this in T54308: scale its not so smooth with Wacom.Mar 13 2018, 6:02 PM
Mike (LMProductions) mentioned this in T56083: Blender consistently deleting Bake files.Jul 22 2018, 11:20 PM
Andrew (andyhav) mentioned this in T61687: 2.80 beta Zooming and Scale and Few Other Issues.Feb 18 2019, 9:44 PM
Alex (newyear) mentioned this in T61716: Texture Paint - Locked into solid color rendering/Incorrect display of shader node configuration/Contextual menu auto closes.Feb 19 2019, 4:34 PM
Robert Rioux (riouxr) mentioned this in T64653: Viewport dead on Macpro.May 15 2019, 3:18 PM
Alex (newyear) mentioned this in T66582: Floaty disconnected bones appearing on complex rigs.Jul 8 2019, 11:04 PM
Joao Morgado (MrJomo) mentioned this in T66784: View port DOF picking not working.Jul 12 2019, 5:26 PM
Joao Morgado (MrJomo) mentioned this in T66791: Smoke Shadow glitches in Cycles (workaround only with Fluid "Empty Space" option).Jul 12 2019, 6:38 PM
Joao Morgado (MrJomo) mentioned this in T66792: Cycles won't render smoke without caching.Jul 12 2019, 6:41 PM
Alex (newyear) mentioned this in T67079: Segmentation fault: 11 Crash.Jul 16 2019, 8:27 PM
Artur (artur.machura) mentioned this in T70680: MAC OS crash.Oct 9 2019, 7:39 PM
Braeden (B-Rae) mentioned this in T70880: Compositor Interactions/Selections fail on dual monitors.Oct 16 2019, 6:12 PM
Dinesh Kumar (dineshk78) mentioned this in T71325: Odd Eevee performance issue.Nov 3 2019, 9:21 PM
rafek yousef (rafek_finearts) mentioned this in T74927: very slow playback if activated thee Auto normalization.Mar 19 2020, 2:28 PM
Dinesh Kumar (dineshk78) mentioned this in T66231: Performance degradation of Principled Shader in Eevee when metallic is turned off.Jun 4 2020, 11:55 AM
Juan Pablo Riebeling (jovenpaul) mentioned this in T80207: FBX Animation Export - Unexpected Rotations.Aug 29 2020, 1:45 AM
Philip Watkin (dolphinstudios) mentioned this in T86849: blender crashes when adding a Hair particle system .Mar 23 2021, 1:10 PM
Chad Gleason (fahr) mentioned this in T86877: Blender crashes when trying to open the "Spring" and "Barbershop" demos on a 2013 Mac Pro with D700 graphics.Mar 24 2021, 8:59 AM
Chad Gleason (fahr) mentioned this in T87069: Blender Crashes Randomly and Often on a Mac Pro with AMD graphics.Mar 31 2021, 3:40 AM
Chad Gleason (fahr) mentioned this in T70856: macOS: Blender crashes when I log in/wake the display.Apr 6 2021, 9:40 PM
Omar Emara (OmarSquircleArt) mentioned this in T87161: Blender randomly crash without reason in 'glDrawElementsInstancedBaseVertex' (in 'OVERLAY_wireframe_draw' or 'workbench_draw_sample').Mar 24 2022, 3:50 PM
Julian (jirac) mentioned this in T100949: Blender 3.3 Tissue error patch fill baseobject with modifier.Sep 9 2022, 5:19 PM
Mystie Cloud (MystieCloud) mentioned this in T101440: macOS Menubar Auto-Hide Broken, Will Not Unhide.Sep 28 2022, 6:47 PM
Jose Casillas (joecreative) mentioned this in T103097: Blender 3.4 animation Preview playback not working on Mac Pro computer.Dec 10 2022, 6:11 AM

Revision Contents
Changeset List

Diff 2298

View Options

source/blender/gpu/CMakeLists.txt

Loading...
View Options

source/blender/gpu/GPU_simple_shader.h

Loading...
View Options

source/blender/gpu/SConscript

Loading...
View Options

source/blender/gpu/intern/gpu_extensions.c

Loading...
View Options

source/blender/gpu/intern/gpu_simple_shader.c

Loading...
View Options

source/blender/gpu/shaders/gpu_shader_simple_frag.glsl

Loading...
View Options

source/blender/gpu/shaders/gpu_shader_simple_vert.glsl

Loading...