Fix T72028: Crash switching to vertex paint
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 3 2020, 5:25 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Maniphest Tasks

T72028: Crash switching to vertex paint (from editmode, mesh with modifier, after adding/removing geometry in editmode)

Commits

rBc7e28f25d58a: Fix T72028: Crash switching to vertex paint
rB31aefdeec5a6: Fix T72028: Crash switching to vertex paint

Summary

This would happen when done from editmode, on a mesh with any modifier,
after adding/removing geometry in editmode.

Similar to rBba0870713b9b (which did this for weightpaint and sculpt
already), ensure an evaluated depsgraph, otherwise
'runtime.mesh_deform_eval' would not be up to date causing problems
later.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 3 2020, 5:25 PM

Harbormaster completed remote builds in B6923: Diff 22335.Mar 3 2020, 5:25 PM

Seems fine.

This revision is now accepted and ready to land.Mar 3 2020, 5:50 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 3 2020, 6:13 PM

Closed by commit rB31aefdeec5a6: Fix T72028: Crash switching to vertex paint (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 3 2020, 7:47 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB31aefdeec5a6: Fix T72028: Crash switching to vertex paint.

Nathan Letwory (jesterking) added a commit: rBc7e28f25d58a: Fix T72028: Crash switching to vertex paint.Mar 10 2020, 1:53 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

paint_vertex.c

3 lines

Diff 22341

View Options

source/blender/editors/sculpt_paint/paint_vertex.c

Fix T72028: Crash switching to vertex paintClosedPublicActions