Fix T73049: drag&drop on panels in 3d view behaves unexpectedly
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 4 2020, 4:17 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Julian Eisel (Severin)
Brecht Van Lommel (brecht)

Maniphest Tasks

T73049: Drag&drop of an object into a panel in the 3D view duplicates the object

Commits

rB649fdc793851: Fix T73049: Drag & drop on overlapping panels behaves incorrectly

Summary

Previously, the poll functions of the dropboxes in the 3D viewport would return
true, even if the mouse is actually hovering an overlapping region.

This patch just adds a check for whether the mouse is actually over the main region
and not over an overlapping region.

Diff Detail

Repository

rB Blender

Branch

drop-into-viewport-fix (branched from master)

Build Status

Buildable 7133
Build 7133: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 4 2020, 4:17 PM

Harbormaster completed remote builds in B6943: Diff 22376.Mar 4 2020, 4:17 PM

Jacques Lucke (JacquesLucke) added a task: T73049: Drag&drop of an object into a panel in the 3D view duplicates the object.Mar 4 2020, 4:17 PM

Brecht Van Lommel (brecht) requested changes to this revision.Mar 9 2020, 7:38 PM

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Brecht Van Lommel (brecht) added inline comments.

source/blender/editors/space_view3d/space_view3d.c
443–447	Can we make this a bit more generic? Loop over regions in `ScrArea`, then check if they are overlapping with `ED_region_is_overlap`. Ideally this can then also be implemented in `wm_dragdrop.c` so it works for all editors that might have overlapping regions, which includes the image editor.