Page MenuHome

Code Cleanup: Compositor Remove OpenCL Rendering
AbandonedPublic

Authored by Aaron Carlisle (Blendify) on Mar 5 2020, 6:19 AM.

Details

Summary

Current GPU support is very limited, causes duplication of node
implementation, not friendly for data transfer, does not give
measurable speedup in production setups.

Removing the code makes it easier to refactor the system
to be faster and more responsive on CPU.

GPU integration might get re-introduced later with an upgraded design.

Part of T73586

Diff Detail

Event Timeline

This makes high quality blurs unworkable slow, not sure what this has to do with code cleanup or if this is the right moment to do it. I see it is mentioned in the overall ticket. But I am missing the overall plan.

Please test with a Blur with Bokeh Enabled, Bokeh Blur, Defocus and see the speed improvements when OpenCL is enabled.

I will leave that up to the project maintainers to discuss.

I can assure, without OpenCL, All operations related to blur are slow.

Currently, the compositor gets stuck in an infinite loop, I am assuming the worker isn't assigning to the CPU. If we do want to remove this someone can commander this, I probably wont have time to finish this.

Given that T74491: Compositor improvement plan was created, I assume @Jeroen Bakker (jbakker) and @Sergey Sharybin (sergey) had some discussion about this. I'm not sure if removing GPU support is something we want to do now, or closer to when that tasks starts being worked on.