Curvetools enumproperty has spaces in identifier
AbandonedPublic
Actions

Authored by Roel Koster (kostex) on Mar 6 2020, 2:35 PM.

Details

Reviewers

Vladimir Spivak (cwolf3d)
Brendon Murphy (meta-androcto)
Brecht Van Lommel (brecht)

Maniphest Tasks

T74493: CurveTools has spaces in enum identifiers

Summary

To me this is a bug.. but I was asked to post it here instead..

EnumProperties do not allow for spaces in their identifiers (first element)
This patch changes that..
Fix T74493

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Roel Koster (kostex) created this revision.Mar 6 2020, 2:35 PM

Ankit Meel (ankitm) added reviewers: Vladimir Spivak (cwolf3d), Brendon Murphy (meta-androcto).Mar 6 2020, 6:30 PM

Ankit Meel (ankitm) added a project: Python API.

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

Ankit Meel (ankitm) added a task: T74493: CurveTools has spaces in enum identifiers.

Thanks for the fix. Any change should be submitted through the code review form so we can review it more easily, and so we're sure you've agreed to submitting the code under the right license.

This revision now requires changes to proceed.Mar 9 2020, 4:00 PM

Brecht Van Lommel (brecht) added inline comments.Mar 9 2020, 4:01 PM

curve_tools/__init__.py
131–132	Only changing it here can't work, there must be other code using this enum which was not updated.
149–150	Only changing it here can't work, there must be other code using this enum which was not updated.