Page MenuHome
Differential D7049

Fix T74500: Rebuild the Face Sets datalayer after slicing the geometry
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Mar 6 2020, 4:34 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Brecht Van Lommel (brecht)
Maniphest Tasks
T74500: Sculpt: Crash when use "Mask Slice and Fill Holes"
Commits
rB0030e6a2fc26: Fix T74500: Rebuild the Face Sets datalayer after slicing the geometry
Summary

Was crashing SculptSession data will not longer be valid if the total
number of polys is modified when rendering the mesh again.
This deletes all face sets in the mesh when slicing the mask. I'll try
to add code to generate a new face set in with faces that are created
when filling the holes, but for now this avoids the crash.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Mar 6 2020, 4:34 PM
Harbormaster completed remote builds in B6998: Diff 22480.Mar 6 2020, 4:34 PM
Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Mar 6 2020, 4:34 PM
Brecht Van Lommel (brecht) accepted this revision.Mar 9 2020, 7:24 PM
This revision is now accepted and ready to land.Mar 9 2020, 7:24 PM
Brecht Van Lommel (brecht) added a comment.Mar 9 2020, 7:25 PM

Since this is a workaround, it would be good to leave a comment in the code explaining that, in case you don't get to fixing this soon.

Closed by commit rB0030e6a2fc26: Fix T74500: Rebuild the Face Sets datalayer after slicing the geometry (authored by Pablo Dobarro (pablodp606)). · Explain WhyMar 9 2020, 7:41 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rB0030e6a2fc26: Fix T74500: Rebuild the Face Sets datalayer after slicing the geometry.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
11 lines

Diff 22581

View Options

source/blender/editors/mesh/editmesh_mask_extract.c

Loading...