BGE: Fix for CreateConstraint API
ClosedPublic
Actions

Authored by Thomas Szepe (hg1) on Aug 3 2014, 6:02 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Jorge Bernal (lordloki)
Mitchell Stokes (moguri)
Inês Almeida (brita_)

Commits

rBSeaabe9d6c609: BGE: Fix for CreateConstraint API
rBeaabe9d6c609: BGE: Fix for CreateConstraint API

Summary

This patch fix two bugs related to CreateConstraint().

Disable linked collision only working with 6DoF constraints.
If all pivot axis rotations setted to zero the linked object disappears.

LineHinge_Constraint.blend336 KBDownload

Diff Detail

Event Timeline

Thomas Szepe (hg1) updated this revision to Diff 2306.Aug 3 2014, 6:02 PM

Thomas Szepe (hg1) retitled this revision from to BGE: Fix for CreateConstraint API.

Thomas Szepe (hg1) updated this object.

Thomas Szepe (hg1) added a reviewer: Mitchell Stokes (moguri).

Wow thanks, I will test it! Will it be added on master?

This bug is caused by setting only 10 parameters in the else condition. So in "axis1.x" (parameter 10) will be written with int 0. and the other parameters are not written.
Only in the DummyPhysicsEnvironment there is a method with only 10 parameters. So I think this is an relict from the old sumo engine. The sake of completeness we should change the method in the DummyPhysicsEnvironment also to 16 parameters, which is actually missing in this patch.

Looks good to me.

Note: DummyPhysicsEnvironment already has a CreateConstrain with 16 parameters

This revision is now accepted and ready to land.Feb 25 2015, 11:48 AM

Closed by commit rBeaabe9d6c609: BGE: Fix for CreateConstraint API (authored by Thomas Szepe (hg1)). · Explain WhyFeb 26 2015, 8:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

gameengine/

Ketsji/

KX_PyConstraintBinding.cpp

39 lines

Diff 2306

View Options

source/gameengine/Ketsji/KX_PyConstraintBinding.cpp

BGE: Fix for CreateConstraint APIClosedPublicActions