UI: Default Theme update
AbandonedPublic
Actions

Authored by Pablo Vazquez (pablovazquez) on Mar 6 2020, 7:11 PM.

Details

Reviewers

William Reynish (billreynish)
Julian Eisel (Severin)
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Summary

This patch includes the following tweaks to the default theme.

To make reviewing easier, this is just one patch, can be committed
by parts to make it easier to revert later on just in case.

FIX: Graph Editor header to match Dopesheet's.
NLA Sound and Meta strips to match VSE's.
Lighter marker lines, to tell them apart from grid lines.
Subtle Gradient Vignette in 3D Viewport, helps to lead the eye to the center and read corner labels better.
Data type correspond with modes. (See T74358)

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 7006
Build 7006: arc lint + arc unit

Event Timeline

Pablo Vazquez (pablovazquez) created this revision.Mar 6 2020, 7:11 PM

Harbormaster completed remote builds in B7004: Diff 22487.Mar 6 2020, 7:11 PM

UI: Default Theme update

Tweak UV Editor to match 3D Viewport

Harbormaster completed remote builds in B7006: Diff 22489.Mar 6 2020, 7:22 PM

UI: Default Theme update

Tweak UV Editor to match 3D Viewport

OK I'm terrible at updating this via arcanist, not sure the image editor changes made it, will update manually from now on.

Harbormaster completed remote builds in B7007: Diff 22490.Mar 6 2020, 7:24 PM

Tested. Changes seem alright with me.

This revision is now accepted and ready to land.Mar 7 2020, 9:11 PM

Whoa, not a fan of those colors in edit mode.
But I use a custom theme, so I'm good. 👍

noki paike (amonpaike) awarded a token.Mar 8 2020, 12:47 PM

The 3D viewport is now quite a bit darker than before, more close in color to the other editors. I'm not sure there is a good way to have the vignette and that distinction at the same time, but I always liked having the 3D viewport with a background color that is quite distinct from other editors.

Adding @Campbell Barton (campbellbarton) and @Clément Foucault (fclem) since they were involved in tweaking the colors for edit mode overlays.

Brecht Van Lommel (brecht) accepted this revision.Mar 9 2020, 6:03 PM

We had a discussion some time ago about yellow/orange being brighter than green.

This change was previously committed, then reverted after discussion with the UI team rB97047db16ce6748f30c0e24f0a2053a11286c5fb, with the statement:

While this consistency is useful, green selection in edit mode does not stand out as much as orange. This can cause problems for some users, it seems to depend on the person. Overall the risk of making the change at this point in the release cycle is too high.

As far as I can see there haven't been any significant changes since then rB5827a47280a0: Theme: match outliner/properties colors with modes in viewport.

Comparisons from a while ago, with updates on master.

In rB5827a47280a0128d0fc47b7c5609058a472bf29f#231384, @Campbell Barton (campbellbarton) wrote:

The green color used is much less bright, making it blend in with mid-tones.

Stick bones are now brighter when un-selected.

Edit-mesh selection color now makes it easy to miss small selected areas (shoe area for eg).

Updated for recent changes:

Updated Comparisons (comparing this patch against master)

I would like to see more extensive testing and comparisons when making theme changes (not just a few test images which happen to look nice with the new theme).

We should make sure changes are not making any display modes measurably worse too.

Besides the issue of green not being as bright a color (noted in last post).

The current theme uses different hue's to distinguish between edge/face, this theme uses the exactly the same hue for both.

This means alpha colors can overlay in wire-frame-mode and merge into a single color.

Before & after comparison with this patch.