Use Blendloader API for modifiers
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 8 2020, 1:07 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Bastien Montagne (mont29)
Campbell Barton (campbellbarton)

Summary

This uses the blenloader api proposed in D7061 to decentralize the file writing/reading code of modifiers. I did not touch the fluid modifier(s) yet.

Furthermore this also moves the blenloader for point caches, curve mappings and curve profiles into blenkernel.

Diff Detail

Repository

rB Blender

Branch

arc-blenloader-api-modifiers (branched from master)

Build Status

Buildable 7047
Build 7047: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 8 2020, 1:07 PM

Harbormaster completed remote builds in B7018: Diff 22509.Mar 8 2020, 1:07 PM

Jacques Lucke (JacquesLucke) added a parent revision: D7061: Blenloader API.Mar 8 2020, 1:11 PM

Jacques Lucke (JacquesLucke) removed a parent revision: D7061: Blenloader API.

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Mar 8 2020, 1:16 PM

Jacques Lucke (JacquesLucke) added a parent revision: D7061: Blenloader API.

Test patch dependencies

Harbormaster completed remote builds in B7020: Diff 22511.Mar 8 2020, 2:17 PM

test

Harbormaster completed remote builds in B7023: Diff 22514.Mar 8 2020, 2:25 PM

Jacques Lucke (JacquesLucke) mentioned this in D7061: Blenloader API.Mar 8 2020, 2:27 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Mar 8 2020, 2:29 PM

Jacques Lucke (JacquesLucke) added reviewers: Brecht Van Lommel (brecht), Bastien Montagne (mont29), Campbell Barton (campbellbarton).Mar 8 2020, 2:34 PM

update according to api changes

Harbormaster completed remote builds in B7037: Diff 22531.Mar 9 2020, 12:50 PM

Besides pending naming changes to be decided in D7061, looks good to me.

This revision is now accepted and ready to land.Mar 9 2020, 2:28 PM

change naming convention from blo_read to blend_read

Harbormaster completed remote builds in B7041: Diff 22540.Mar 9 2020, 3:18 PM

fix accidental rename

Harbormaster completed remote builds in B7047: Diff 22553.Mar 9 2020, 4:39 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 9 2020, 5:27 PM

Jacques Lucke (JacquesLucke) mentioned this in D7321: Blenloader API: lib linking and animdata read/write.Apr 3 2020, 2:40 PM

Jacques Lucke (JacquesLucke) added a child revision: D7321: Blenloader API: lib linking and animdata read/write.Apr 6 2020, 11:40 AM

Brecht Van Lommel (brecht) mentioned this in T75724: Extensible Architecture Refactoring.Apr 14 2020, 1:52 PM

Jacques Lucke (JacquesLucke) closed this revision.Aug 6 2020, 12:57 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

5 lines

5 lines

17 lines

8 lines

intern/

colortools.c

26 lines

curveprofile.c

15 lines

pointcache.c

134 lines

blenloader/

intern/

readfile.c

339 lines

writefile.c

198 lines

modifiers/

CMakeLists.txt

1 line

intern/

10 lines

2 lines

21 lines

2 lines

2 lines

2 lines

43 lines

2 lines

MOD_correctivesmooth.c

26 lines

2 lines

2 lines

2 lines

2 lines

66 lines

2 lines

10 lines

2 lines

25 lines

MOD_laplaciandeform.c

19 lines

MOD_laplaciansmooth.c

2 lines

2 lines

2 lines

2 lines

34 lines

MOD_meshsequencecache.c

11 lines

2 lines

2 lines

2 lines

2 lines

11 lines

MOD_particleinstance.c

2 lines

15 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

10 lines

15 lines

56 lines

2 lines

2 lines

2 lines

22 lines

2 lines

MOD_weighted_normal.c

2 lines

MOD_weightvgedit.c

23 lines

MOD_weightvgmix.c

2 lines

MOD_weightvgproximity.c

2 lines

MOD_weld.c

2 lines

MOD_wireframe.c

2 lines

Diff 22553

View Options

source/blender/blenkernel/BKE_colortools.h

View Options

source/blender/blenkernel/BKE_curveprofile.h

View Options

source/blender/blenkernel/BKE_modifier.h

View Options

source/blender/blenkernel/BKE_pointcache.h

View Options

source/blender/blenkernel/intern/colortools.c

View Options

source/blender/blenkernel/intern/curveprofile.c

View Options

source/blender/blenkernel/intern/pointcache.c

View Options

source/blender/blenloader/intern/readfile.c

View Options

source/blender/blenloader/intern/writefile.c

View Options

source/blender/modifiers/CMakeLists.txt

View Options

source/blender/modifiers/intern/MOD_armature.c

View Options

source/blender/modifiers/intern/MOD_array.c

View Options

source/blender/modifiers/intern/MOD_bevel.c

View Options

source/blender/modifiers/intern/MOD_boolean.c

View Options

source/blender/modifiers/intern/MOD_build.c

View Options

source/blender/modifiers/intern/MOD_cast.c

View Options

source/blender/modifiers/intern/MOD_cloth.c

View Options

source/blender/modifiers/intern/MOD_collision.c

View Options

source/blender/modifiers/intern/MOD_correctivesmooth.c

View Options

source/blender/modifiers/intern/MOD_curve.c

View Options

source/blender/modifiers/intern/MOD_datatransfer.c

View Options

source/blender/modifiers/intern/MOD_decimate.c

View Options

source/blender/modifiers/intern/MOD_displace.c

View Options

source/blender/modifiers/intern/MOD_dynamicpaint.c

View Options

source/blender/modifiers/intern/MOD_edgesplit.c

View Options

source/blender/modifiers/intern/MOD_explode.c

View Options

source/blender/modifiers/intern/MOD_fluid.c

View Options

source/blender/modifiers/intern/MOD_hook.c

View Options

source/blender/modifiers/intern/MOD_laplaciandeform.c

View Options

source/blender/modifiers/intern/MOD_laplaciansmooth.c

View Options

source/blender/modifiers/intern/MOD_lattice.c

View Options

source/blender/modifiers/intern/MOD_mask.cc

View Options

source/blender/modifiers/intern/MOD_meshcache.c

View Options

source/blender/modifiers/intern/MOD_meshdeform.c

View Options

source/blender/modifiers/intern/MOD_meshsequencecache.c

View Options

source/blender/modifiers/intern/MOD_mirror.c

View Options

source/blender/modifiers/intern/MOD_multires.c

View Options

source/blender/modifiers/intern/MOD_none.c

View Options

source/blender/modifiers/intern/MOD_normal_edit.c

View Options

source/blender/modifiers/intern/MOD_ocean.c

View Options

source/blender/modifiers/intern/MOD_particleinstance.c

View Options

source/blender/modifiers/intern/MOD_particlesystem.c

View Options

source/blender/modifiers/intern/MOD_remesh.c

View Options

source/blender/modifiers/intern/MOD_screw.c

View Options

source/blender/modifiers/intern/MOD_shapekey.c

View Options

source/blender/modifiers/intern/MOD_shrinkwrap.c

View Options

source/blender/modifiers/intern/MOD_simpledeform.c

View Options

source/blender/modifiers/intern/MOD_skin.c

View Options

source/blender/modifiers/intern/MOD_smooth.c

View Options

source/blender/modifiers/intern/MOD_softbody.c

View Options

source/blender/modifiers/intern/MOD_solidify.c

View Options

source/blender/modifiers/intern/MOD_subsurf.c

View Options

source/blender/modifiers/intern/MOD_surface.c

View Options

source/blender/modifiers/intern/MOD_surfacedeform.c

View Options

source/blender/modifiers/intern/MOD_triangulate.c

View Options

source/blender/modifiers/intern/MOD_uvproject.c

View Options

source/blender/modifiers/intern/MOD_uvwarp.c

View Options

source/blender/modifiers/intern/MOD_warp.c

View Options

source/blender/modifiers/intern/MOD_wave.c

View Options

source/blender/modifiers/intern/MOD_weighted_normal.c

View Options

source/blender/modifiers/intern/MOD_weightvgedit.c

View Options

source/blender/modifiers/intern/MOD_weightvgmix.c

View Options

source/blender/modifiers/intern/MOD_weightvgproximity.c

View Options

source/blender/modifiers/intern/MOD_weld.c

View Options

source/blender/modifiers/intern/MOD_wireframe.c

Use Blendloader API for modifiersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22553

source/blender/blenkernel/BKE_colortools.h

source/blender/blenkernel/BKE_curveprofile.h

source/blender/blenkernel/BKE_modifier.h

source/blender/blenkernel/BKE_pointcache.h

source/blender/blenkernel/intern/colortools.c

source/blender/blenkernel/intern/curveprofile.c

source/blender/blenkernel/intern/pointcache.c

source/blender/blenloader/intern/readfile.c

source/blender/blenloader/intern/writefile.c

source/blender/modifiers/CMakeLists.txt

source/blender/modifiers/intern/MOD_armature.c

source/blender/modifiers/intern/MOD_array.c

source/blender/modifiers/intern/MOD_bevel.c

source/blender/modifiers/intern/MOD_boolean.c

source/blender/modifiers/intern/MOD_build.c

source/blender/modifiers/intern/MOD_cast.c

source/blender/modifiers/intern/MOD_cloth.c

source/blender/modifiers/intern/MOD_collision.c

source/blender/modifiers/intern/MOD_correctivesmooth.c

source/blender/modifiers/intern/MOD_curve.c

source/blender/modifiers/intern/MOD_datatransfer.c

source/blender/modifiers/intern/MOD_decimate.c

source/blender/modifiers/intern/MOD_displace.c

source/blender/modifiers/intern/MOD_dynamicpaint.c

source/blender/modifiers/intern/MOD_edgesplit.c

source/blender/modifiers/intern/MOD_explode.c

source/blender/modifiers/intern/MOD_fluid.c

source/blender/modifiers/intern/MOD_hook.c

source/blender/modifiers/intern/MOD_laplaciandeform.c

source/blender/modifiers/intern/MOD_laplaciansmooth.c

source/blender/modifiers/intern/MOD_lattice.c

source/blender/modifiers/intern/MOD_mask.cc

source/blender/modifiers/intern/MOD_meshcache.c

source/blender/modifiers/intern/MOD_meshdeform.c

source/blender/modifiers/intern/MOD_meshsequencecache.c

source/blender/modifiers/intern/MOD_mirror.c

source/blender/modifiers/intern/MOD_multires.c

source/blender/modifiers/intern/MOD_none.c

source/blender/modifiers/intern/MOD_normal_edit.c

source/blender/modifiers/intern/MOD_ocean.c

source/blender/modifiers/intern/MOD_particleinstance.c

source/blender/modifiers/intern/MOD_particlesystem.c

source/blender/modifiers/intern/MOD_remesh.c

source/blender/modifiers/intern/MOD_screw.c

source/blender/modifiers/intern/MOD_shapekey.c

source/blender/modifiers/intern/MOD_shrinkwrap.c

source/blender/modifiers/intern/MOD_simpledeform.c

source/blender/modifiers/intern/MOD_skin.c

source/blender/modifiers/intern/MOD_smooth.c

source/blender/modifiers/intern/MOD_softbody.c

source/blender/modifiers/intern/MOD_solidify.c

source/blender/modifiers/intern/MOD_subsurf.c

source/blender/modifiers/intern/MOD_surface.c

source/blender/modifiers/intern/MOD_surfacedeform.c

source/blender/modifiers/intern/MOD_triangulate.c

source/blender/modifiers/intern/MOD_uvproject.c

source/blender/modifiers/intern/MOD_uvwarp.c

source/blender/modifiers/intern/MOD_warp.c

source/blender/modifiers/intern/MOD_wave.c

source/blender/modifiers/intern/MOD_weighted_normal.c

source/blender/modifiers/intern/MOD_weightvgedit.c

source/blender/modifiers/intern/MOD_weightvgmix.c

source/blender/modifiers/intern/MOD_weightvgproximity.c

source/blender/modifiers/intern/MOD_weld.c

source/blender/modifiers/intern/MOD_wireframe.c

Use Blendloader API for modifiers
ClosedPublic
Actions

Revision Contents
Changeset List