Page MenuHome

Depsgraph: fix crash caused by removing unused NO-OP nodes too early
ClosedPublic

Authored by Sybren A. Stüvel (sybren) on Mar 9 2020, 3:52 PM.

Details

Summary

Unused no-op operation nodes are not bound to a callback function, and have no outgoing relations. Incoming relations of such nodes are removed since ff60dd8b18ed00902e5bdfd36882072db7af8735. However, this was done too broadly, causing too many relations to be lost and indirectly linked objects to be unevaluated.

This commit introduces a DEPSOP_FLAG_FAKE_USER flag for operation nodes, which indicates they are not to be removed, even when they appear to be unused.

Diff Detail

Repository
rB Blender

Event Timeline

  • fake user → pinned
This revision is now accepted and ready to land.Mar 9 2020, 3:56 PM