Paths

Table of Contentst

Differential D7077

Preferences/Editing/Miscellaneous. Node Auto-offset Margin of type (PROP_PIXEL) 'px'?
ClosedPublic
Actions

Authored by Adrian Newton (TFS) on Mar 9 2020, 4:34 PM.

Tags

None

Subscribers

Julian Eisel (Severin)

Details

Reviewers

Brecht Van Lommel (brecht)

Group Reviewers

Commits

rBa46836854049: UI: use pixel units for tile sizes and node auto-offset margin

Diff Detail

Repository: rB Blender

Event Timeline

Adrian Newton (TFS) created this revision.Mar 9 2020, 4:34 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 9 2020, 5:25 PM

This revision is now accepted and ready to land.Mar 9 2020, 5:25 PM

Closed by commit rBa46836854049: UI: use pixel units for tile sizes and node auto-offset margin (authored by Adrian Newton (TFS), committed by Brecht Van Lommel (brecht)). · Explain WhyMar 9 2020, 6:49 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBa46836854049: UI: use pixel units for tile sizes and node auto-offset margin.

Brecht Van Lommel (brecht) mentioned this in D7079: Cycles Rendering Tile Size (X,Y) dimensions. Change to PROP_PIXEL?.Mar 9 2020, 7:20 PM

The reason I initially didn't use PROP_PIXEL for node auto-offset was because DPI gets applied to it. So I'm not sure if we should actually do it, strictly speaking it's not a pixel value.

For the tile size this doesn't seem to be the case.

We have the same for other preferences like gizmo size.

I think it is a pixel size before DPI scaling, which isn't that different than an image size in pixels before zooming or DPI scaling.

I think that's fine as a definition, but we should probably make that explicit somewhere. Don't see a better place than the enum item definition for it, so would propose something like this:

P1289 RNA: Comment re PROP_PIXEL property DPI handling

1	diff --git a/source/blender/makesrna/RNA_types.h b/source/blender/makesrna/RNA_types.h
2	index 7a85f5c372f..66a5df001de 100644
3	--- a/source/blender/makesrna/RNA_types.h
4	+++ b/source/blender/makesrna/RNA_types.h
5	@@ -121,6 +121,8 @@ typedef enum PropertySubType {
6	PROP_PASSWORD = 6,
7
8	/* numbers */
9	+ /** A dimension in pixel units, possibly before DPI scaling (so value may not be the final pixel
10	+ * value but the one to apply DPI scale to). */
11	PROP_PIXEL = 12,
12	PROP_UNSIGNED = 13,
13	PROP_PERCENTAGE = 14,

Adding a comment is fine with me.

Julian Eisel (Severin) mentioned this in rBe06888cf897f: Cleanup: Add comment explaining DPI influence on RNA pixel-properties.Mar 10 2020, 3:21 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

4 lines

2 lines

Diff 22573

source/blender/makesrna/intern/rna_scene.c

Loading...

source/blender/makesrna/intern/rna_userdef.c

Loading...