Details

Reviewers

Jeroen Bakker (jbakker)
Dalai Felinto (dfelinto)

Maniphest Tasks

T74613: Sculpting base color is green

Commits

rBb37482bc3d86: Fix T74613: Assign the default face set color in the versioning code

Summary

A default face set color was not being set in previously saved meshes,
so it will always render the default face set with a random color until
the colors were recalculated.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Mar 10 2020, 1:32 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Mar 10 2020, 1:33 PM

Harbormaster completed remote builds in B7064: Diff 22619.Mar 10 2020, 1:34 PM

Initialize the default face set color when creating the datalayer for

Harbormaster completed remote builds in B7066: Diff 22627.Mar 10 2020, 1:56 PM

This doversion code won't work for files saved in master. For example attached file:

green.blend888 KBDownload

This revision now requires changes to proceed.Mar 10 2020, 2:25 PM

bump subversion

Harbormaster completed remote builds in B7068: Diff 22632.Mar 10 2020, 3:18 PM

This has a few issues:

Neglected to shift do_versions_after_linking_280 as well
The new code is not under the conditioning of the new version. Which means me->face_sets_color_default = abs(face_sets[0]); is set again at all times.

If this is the intended behaviour this should happen elsewhere (in readfile.c)

Bump do_versions_after_linking

Harbormaster completed remote builds in B7069: Diff 22634.Mar 10 2020, 3:42 PM

As far as versioning (and my tests go) it seems fine. Not sure of the internals of face set though.

This revision is now accepted and ready to land.Mar 10 2020, 3:51 PM

Closed by commit rBb37482bc3d86: Fix T74613: Assign the default face set color in the versioning code (authored by Pablo Dobarro (pablodp606)). · Explain WhyMar 10 2020, 3:57 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rBb37482bc3d86: Fix T74613: Assign the default face set color in the versioning code.

Fix T74613: Assign the default face set color in the versioning code
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 22636

source/blender/blenkernel/BKE_blender_version.h

source/blender/blenkernel/intern/paint.c

source/blender/blenloader/intern/versioning_280.c

Fix T74613: Assign the default face set color in the versioning codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22636

source/blender/blenkernel/BKE_blender_version.h

source/blender/blenkernel/intern/paint.c

source/blender/blenloader/intern/versioning_280.c

Fix T74613: Assign the default face set color in the versioning code
ClosedPublic
Actions

Revision Contents
Changeset List