Differential D7096

Fix T74626: Wrong Face Sets overlay rendering in smooth shading
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Mar 10 2020, 6:34 PM.

Tags

None

Subscribers

None

Details

Reviewers

Jeroen Bakker (jbakker)

Maniphest Tasks

T74626: Remeshing with Smooth Normals causes Face Sets unusual behaviour

Commits

rBe4077ea69d5f: Fix T74626: Wrong Face Sets overlay rendering in smooth shading

Summary

The face set color variable needs to be declared inside of the loop in
order to reset it per iteration.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Mar 10 2020, 6:34 PM

Harbormaster completed remote builds in B7076: Diff 22646.Mar 10 2020, 6:34 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Mar 11 2020, 2:30 PM

Jeroen Bakker (jbakker) accepted this revision.Mar 13 2020, 3:45 PM

This revision is now accepted and ready to land.Mar 13 2020, 3:45 PM

Closed by commit rBe4077ea69d5f: Fix T74626: Wrong Face Sets overlay rendering in smooth shading (authored by Pablo Dobarro (pablodp606)). · Explain WhyMar 16 2020, 5:44 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rBe4077ea69d5f: Fix T74626: Wrong Face Sets overlay rendering in smooth shading.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

intern/

2 lines

Diff 22841

source/blender/gpu/intern/gpu_buffers.c

Loading...