Differential D7104

Copy point cache settings when copying cloth modifier
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 11 2020, 12:11 PM.

Tags

None

Subscribers

Bastien Montagne (mont29)

Philipp Oeser (lichtwerk)

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Maniphest Tasks

T71604: Cloth Point Cache settings don't copy after object dupication

Commits

rB6eeaecdd67f6: Cloth: Copy point cache settings when copying cloth modifier

Summary

This fixes the issue mentioned in the comment in T74515.
T74515 itself might actually be more a known limitation than a bug...

Diff Detail

Repository

Branch

copy-point-cache-settings (branched from master)

Build Status

Buildable 7085
Build 7085: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 11 2020, 12:11 PM

Harbormaster completed remote builds in B7085: Diff 22668.Mar 11 2020, 12:11 PM

Philipp Oeser (lichtwerk) added a task: T71604: Cloth Point Cache settings don't copy after object dupication.Mar 11 2020, 12:29 PM

Thx @Jacques Lucke (JacquesLucke)!
I recall talking to @Bastien Montagne (mont29) about this in chat (relating to T71604), and he also did not see a reason to not do it :)

So this would fix T71604

LGTM yes

This revision is now accepted and ready to land.Mar 11 2020, 1:00 PM

Closed by commit rB6eeaecdd67f6: Cloth: Copy point cache settings when copying cloth modifier (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMar 11 2020, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB6eeaecdd67f6: Cloth: Copy point cache settings when copying cloth modifier.

Revision Contents
Changeset List

Path

Size

source/

blender/

modifiers/

intern/

6 lines

Diff 22668

source/blender/modifiers/intern/MOD_cloth.c

Loading...