Fix T63213: Face dots visibility problem
AbandonedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Mar 11 2020, 12:42 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T63213: Face dots visibility problem

Summary

Although it is interesting to have an offset to display a facedot
without intersecting with the faces, this seems to be bringing more
problems than solutions.

The idea of this patch is to remove this bias.

Even without it, the dots don't show overlap when the normal is aligned

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 7087
Build 7087: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Mar 11 2020, 12:42 PM

Harbormaster completed remote builds in B7087: Diff 22671.Mar 11 2020, 12:42 PM

Germano Cavalcante (mano-wii) added a task: T63213: Face dots visibility problem.Mar 11 2020, 12:42 PM

This is on purpose. The facedots should not be cut in half when not viewing the surface from an angle not perpendicular to the normal. We use this bias to avoid this in the general case.

New solution

Check the depth in the vert shader and change the alpha to zero when the point is occluded.

Harbormaster completed remote builds in B7101: Diff 22695.Mar 11 2020, 7:19 PM

I found a problem with the depth test between the facedots.
Selected facedots, even being in the front of others facedots, were sometimes drawn behind or the other way around.
I have not found a good solution for this (creating an empty depth texture just for that is not worth it).
I used the depth_range solution and I replicated the "vert shader depth_test" solution for vertices as well.

Vertices (when not occluded) are now drawn in front of all objects, but this seems to be expected behavior.

Harbormaster completed remote builds in B7109: Diff 22710.Mar 12 2020, 12:26 AM

With this depth_range solution, cursor projection and Auto Depth navigation are problematic if the mouse is over a vertex.

I can't think of an appropriate solution to solve this.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

overlay/

shaders/

edit_mesh_vert.glsl

2 lines

Diff 22671

View Options

source/blender/draw/engines/overlay/shaders/edit_mesh_vert.glsl

Fix T63213: Face dots visibility problemAbandonedPublicActions