Page MenuHome
Differential D7115

Fix T64573: RNA_path_from_ID_to_property fails for pointcaches
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 11 2020, 6:09 PM.

Details

Reviewers
Bastien Montagne (mont29)
Sebastián Barschkis (sebbas)
Campbell Barton (campbellbarton)
Maniphest Tasks
T64573: RNA_path_from_ID_to_property fails for pointcaches [thus ALT+click does as well...]
Commits
rB28827b62f777: Fix T64573: RNA_path_from_ID_to_property fails for pointcaches
Summary

Give pointcaches a proper path function which e.g. also resolves
ALT+click (assign to all selected) not working for anything relating to
pointcaches.

This also cleans up the usage of the 'eModifierTypeFlag_UsesPointCache'
flag (removed from the boolean modifier, added to the softbody modifier).

Diff Detail

Repository
rB Blender
Branch
T64573 (branched from master)
Build Status
Buildable 7099
Build 7099: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 11 2020, 6:09 PM
Harbormaster completed remote builds in B7099: Diff 22693.Mar 11 2020, 6:10 PM
Philipp Oeser (lichtwerk) added a comment.Mar 11 2020, 6:14 PM

Testfile for checking e.g. Alt+click on Cache End (or checking pointcaches now properly return some valid path_from_id()):

T64573.blend759 KBDownload

Philipp Oeser (lichtwerk) added projects: Nodes & Physics, User Interface, Modifiers.Mar 11 2020, 6:15 PM
Philipp Oeser (lichtwerk) added a project: Datablocks and Libraries.
Brecht Van Lommel (brecht) awarded a token.Mar 11 2020, 6:22 PM
Bastien Montagne (mont29) accepted this revision.Mar 24 2020, 10:28 AM

LGTM

This revision is now accepted and ready to land.Mar 24 2020, 10:28 AM
Closed by commit rB28827b62f777: Fix T64573: RNA_path_from_ID_to_property fails for pointcaches (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 24 2020, 10:57 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB28827b62f777: Fix T64573: RNA_path_from_ID_to_property fails for pointcaches.

Revision Contents
Changeset List

PathSize
source/
blender/
makesrna/
intern/
66 lines
modifiers/
intern/
2 lines
3 lines

Diff 22693

View Options

source/blender/makesrna/intern/rna_object_force.c

Loading...
View Options

source/blender/modifiers/intern/MOD_boolean.c

Loading...
View Options

source/blender/modifiers/intern/MOD_softbody.c

Loading...