Page MenuHome
Differential D7135

Fix T67446: UV Editor: support island select mode for box/circle/lasso selections
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 12 2020, 6:56 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Maniphest Tasks
T67446: Box selection in UV editor does not work with Island selection mode
Commits
rBbb89cc51eca3: Fix T67446: UV Editor: support island select mode for box/circle/lasso…
Summary

This also unifys some logic between box/circle/lasso:

  • use early selection test from lasso [makes things faster] in box/circle
  • circle wasnt checking visible face

Diff Detail

Repository
rB Blender
Branch
T67446 (branched from master)
Build Status
Buildable 7139
Build 7139: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 12 2020, 6:56 PM
Harbormaster completed remote builds in B7139: Diff 22750.Mar 12 2020, 6:57 PM
Philipp Oeser (lichtwerk) added a project: Modeling.Mar 12 2020, 6:58 PM
Benjamin Sauder (kioku) awarded a token.Mar 12 2020, 11:29 PM
Campbell Barton (campbellbarton) accepted this revision.Mar 13 2020, 12:26 PM

Patch looks fine. Assume you checked pinned is working properly since the code reads like it could conflict with the selection checks.

source/blender/editors/uvedit/uvedit_ops.c
3523

This limit should be moved to define.

This revision is now accepted and ready to land.Mar 13 2020, 12:26 PM
Philipp Oeser (lichtwerk) updated this revision to Diff 22777.Mar 13 2020, 3:13 PM
  • use define for limit
  • clang format
Harbormaster completed remote builds in B7153: Diff 22777.Mar 13 2020, 3:13 PM
Philipp Oeser (lichtwerk) marked an inline comment as done.Mar 13 2020, 3:15 PM
In D7135#170433, @Campbell Barton (campbellbarton) wrote:

Assume you checked pinned is working properly since the code reads like it could conflict with the selection checks.

Seems to be working as before.

Brecht Van Lommel (brecht) resigned from this revision.Mar 13 2020, 5:25 PM
Philipp Oeser (lichtwerk) closed this revision.Mar 14 2020, 11:25 AM

Committed with minor edit to define rBbb89cc51eca3: Fix T67446: UV Editor: support island select mode for box/circle/lasso…

Philipp Oeser (lichtwerk) added a commit: rBbb89cc51eca3: Fix T67446: UV Editor: support island select mode for box/circle/lasso….Mar 14 2020, 11:25 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
uvedit/
105 lines

Diff 22750

View Options

source/blender/editors/uvedit/uvedit_ops.c

Loading...