Details

Reviewers

Jacques Lucke (JacquesLucke)
Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Commits

rBaa09a46fd736: Objects: add infrastructure for hair, pointcloud, volume modifiers

Summary

There are no modifiers implemented and there is no user visible difference,
but this makes it possible to start implementing them for future releases.

There is no urgency to this review, as I don't plan to add any modifiers for
2.83, but it's convenient to have the whole new-object-types branch merged
into master.

Diff Detail

Repository: rB Blender

Event Timeline

Brecht Van Lommel (brecht) created this revision.Mar 13 2020, 12:52 PM

Harbormaster completed remote builds in B7151: Diff 22774.Mar 13 2020, 12:52 PM

Remove unintentional changes.

Harbormaster completed remote builds in B7152: Diff 22775.Mar 13 2020, 12:55 PM

Brecht Van Lommel (brecht) added a parent revision: D6955: Objects: Eevee and workbench rendering of new Volume, Hair, PointCloud.Mar 13 2020, 12:55 PM

Marking as planned changes. Not sure if it will change, but doesn't need to be in the review queue at the moment.

This is now needed for particle nodes, and will also be useful for further development of pointclouds, hair and volumes.

Brecht Van Lommel (brecht) edited the summary of this revision. (Show Details)Apr 21 2020, 1:20 PM

Rebase on master.

Harbormaster completed remote builds in B7651: Diff 23928.Apr 21 2020, 1:21 PM

Brecht Van Lommel (brecht) removed a parent revision: D6955: Objects: Eevee and workbench rendering of new Volume, Hair, PointCloud.Apr 21 2020, 1:21 PM

Jacques Lucke (JacquesLucke) added inline comments.Apr 21 2020, 2:06 PM

source/blender/blenkernel/intern/hair.c
260	`apply_flag`
source/blender/blenkernel/intern/pointcloud.c
260	Is the modifier responsible for calling `CustomData_duplicate_referenced_layer`, when it wants to change the positions?

Brecht Van Lommel (brecht) marked 2 inline comments as done.Apr 21 2020, 3:02 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/blenkernel/intern/pointcloud.c
260	Modifiers are expected to use either `BKE_pointcloud_new_for_eval` or `BKE_pointcloud_copy_for_eval`, which has a `reference` parameter. When creating a copy referencing data layers, then indeed `CustomData_duplicate_referenced_layer` should be used before modifying them.

Rename to apply_flag

Harbormaster completed remote builds in B7654: Diff 23933.Apr 21 2020, 3:03 PM

Jacques Lucke (JacquesLucke) accepted this revision.Apr 21 2020, 3:06 PM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/blenkernel/intern/pointcloud.c
260	I see, so we create potentially two (shallow) copies of the point cloud for every modifier?

This revision is now accepted and ready to land.Apr 21 2020, 3:06 PM

Jacques Lucke (JacquesLucke) added inline comments.Apr 21 2020, 3:09 PM

source/blender/blenkernel/intern/pointcloud.c
260	Ah, my fault. I just overlooked `pointcloud == pointcloud_input`.

LGTM, think 'cleanup' changes (var renaming, comments tweaking) should be committed separately though? Would also have made the patch a bit less noisy. ;)

Closed by commit rBaa09a46fd736: Objects: add infrastructure for hair, pointcloud, volume modifiers (authored by Brecht Van Lommel (brecht)). · Explain WhyApr 22 2020, 2:20 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBaa09a46fd736: Objects: add infrastructure for hair, pointcloud, volume modifiers.

Objects: add infrastructure for hair, pointcloud, volume modifiersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23968

source/blender/blenkernel/BKE_modifier.h

source/blender/blenkernel/intern/DerivedMesh.c

source/blender/blenkernel/intern/displist.c

source/blender/blenkernel/intern/hair.c

source/blender/blenkernel/intern/lattice.c

source/blender/blenkernel/intern/mesh_convert.c

source/blender/blenkernel/intern/modifier.c

source/blender/blenkernel/intern/multires.c

source/blender/blenkernel/intern/object.c

source/blender/blenkernel/intern/pointcloud.c

source/blender/blenkernel/intern/volume.cc

source/blender/modifiers/intern/MOD_armature.c

source/blender/modifiers/intern/MOD_array.c

source/blender/modifiers/intern/MOD_bevel.c

source/blender/modifiers/intern/MOD_boolean.c

source/blender/modifiers/intern/MOD_build.c

source/blender/modifiers/intern/MOD_cast.c

source/blender/modifiers/intern/MOD_cloth.c

source/blender/modifiers/intern/MOD_collision.c

source/blender/modifiers/intern/MOD_correctivesmooth.c

source/blender/modifiers/intern/MOD_curve.c

source/blender/modifiers/intern/MOD_datatransfer.c

source/blender/modifiers/intern/MOD_decimate.c

source/blender/modifiers/intern/MOD_displace.c

source/blender/modifiers/intern/MOD_dynamicpaint.c

source/blender/modifiers/intern/MOD_edgesplit.c

source/blender/modifiers/intern/MOD_explode.c

source/blender/modifiers/intern/MOD_fluid.c

source/blender/modifiers/intern/MOD_hook.c

source/blender/modifiers/intern/MOD_laplaciandeform.c

source/blender/modifiers/intern/MOD_laplaciansmooth.c

source/blender/modifiers/intern/MOD_lattice.c

source/blender/modifiers/intern/MOD_mask.cc

source/blender/modifiers/intern/MOD_meshcache.c

source/blender/modifiers/intern/MOD_meshdeform.c

source/blender/modifiers/intern/MOD_meshsequencecache.c

source/blender/modifiers/intern/MOD_mirror.c

source/blender/modifiers/intern/MOD_multires.c

source/blender/modifiers/intern/MOD_none.c

source/blender/modifiers/intern/MOD_normal_edit.c

source/blender/modifiers/intern/MOD_ocean.c

source/blender/modifiers/intern/MOD_particleinstance.c

source/blender/modifiers/intern/MOD_particlesystem.c

source/blender/modifiers/intern/MOD_remesh.c

source/blender/modifiers/intern/MOD_screw.c

source/blender/modifiers/intern/MOD_shapekey.c

source/blender/modifiers/intern/MOD_shrinkwrap.c

source/blender/modifiers/intern/MOD_simpledeform.c

source/blender/modifiers/intern/MOD_skin.c

source/blender/modifiers/intern/MOD_smooth.c

source/blender/modifiers/intern/MOD_softbody.c

source/blender/modifiers/intern/MOD_solidify.c

source/blender/modifiers/intern/MOD_solidify_extrude.c

source/blender/modifiers/intern/MOD_solidify_nonmanifold.c

source/blender/modifiers/intern/MOD_solidify_util.h

source/blender/modifiers/intern/MOD_subsurf.c

source/blender/modifiers/intern/MOD_surface.c

source/blender/modifiers/intern/MOD_surfacedeform.c

source/blender/modifiers/intern/MOD_triangulate.c

source/blender/modifiers/intern/MOD_uvproject.c

source/blender/modifiers/intern/MOD_uvwarp.c

source/blender/modifiers/intern/MOD_warp.c

source/blender/modifiers/intern/MOD_wave.c

source/blender/modifiers/intern/MOD_weighted_normal.c

source/blender/modifiers/intern/MOD_weightvgedit.c

source/blender/modifiers/intern/MOD_weightvgmix.c

source/blender/modifiers/intern/MOD_weightvgproximity.c

source/blender/modifiers/intern/MOD_weld.c

source/blender/modifiers/intern/MOD_wireframe.c

Objects: add infrastructure for hair, pointcloud, volume modifiers
ClosedPublic
Actions

Revision Contents
Changeset List