Rendering workspace: Slot, View Layer & Combined drop downs, displaying label before data
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Mar 13 2020, 3:28 PM.

Details

Reviewers

William Reynish (billreynish)
Brecht Van Lommel (brecht)
Adrian Newton (TFS)
Hans Goudey (HooglyBoogly)

Group Reviewers

User Interface

Commits

rB864c8068639a: UI: Reorder enums in render results image editor header

Summary

Render Default Cube.
Go to Rendering workspace.
Select either the Slot1, View Layer or Combined drop downs.

You should get this:

If you flip the header to the bottom, you get this:

I have looked around and the issue lies in Blender\Editors\space_image\image_buttons.c

This Diff resolves this particular, within this workspace, and brings it into line with the rest of Blender.

Additionally, the Slot information is displayed in Slot 8 -> Slot 1 order. If it would be better in the order of Slot 1 -> Slot 8, let me know and i'll submit another patch.

Diff Detail

Repository: rB Blender

Event Timeline

Adrian Newton (TFS) created this revision.Mar 13 2020, 3:28 PM

I have included another diff to change the Rendering Slot drop down, Slot order if it's a desired change.

Rendering workspace: Render Slot order - current:

Rendering workspace: Render Slot order - proposed:

Diff:

Render Slot reorder - proposed.diff1 KBDownload

Not sure why these were flipped, but yes, it should be consistent.

Also we should order the slots sequentially, yes.

This revision is now accepted and ready to land.Mar 17 2020, 7:57 PM

This still isn't quite right I think? The label is supposed to be furthest away from the mouse cursor like other enum menus.

This revision now requires changes to proceed.Mar 19 2020, 8:45 PM

I could be wrong, but I think the only thing needed is the "other" patch, pasted into the first comment, that puts the slots in ascending order.

That we put the "headers" for these enums at the end might seem a bit weird but is how we do it all over the place. Personally I'd rather it not shown at all most of the time, but that is another issue. LOL

Brecht.

The patch covers the movement of the Label to the appropriate location, and the further attached diff (Render Slot reorder - proposed.diff) covers the reorder of the Slot numbers.
I attached it separately as I wasn't sure both changes would be accepted together as a single diff.

stefano severi (Tetone) awarded a token.Mar 21 2020, 8:24 AM

@Adrian Newton (TFS) I think it's okay to include the two diffs in the same patch here, they affect the same menu. More generally though, just make another patch if you have another diff. Something pasted in comments isn't really the best way to handle it.

No activity here for a while, I will commandeer for the update.
In fact, everything is already fine here, I'll just change the View Layer order as well.

Yevgeny Makarov (jenkm) updated this revision to Diff 32126.Dec 17 2020, 9:50 PM

What about when the header is on the bottom, is the goal of the patch to use the same top to bottom ordering for both cases? I'm fine not doing that, this seems like an improvement already, either way though.

This includes quite a few non-functional cleanup changes though, those should be split off and committed separately.

This revision now requires changes to proceed.Dec 17 2020, 10:55 PM

What about when the header is on the bottom, is the goal of the patch to use the same top to bottom ordering for both cases?

No, this is what the original patch was, I just combined two separate diffs. (my changes are only for View Layers)

I'm not sure that we change the sorting depending on the direction anywhere:

Okay, for some reason I thought that's what the earlier version of this patch did. Looks good to me

This revision now requires review to proceed.Dec 20 2020, 4:42 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 20 2020, 5:06 AM

Closed by commit rB864c8068639a: UI: Reorder enums in render results image editor header (authored by Yevgeny Makarov (jenkm), committed by Hans Goudey (HooglyBoogly)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB864c8068639a: UI: Reorder enums in render results image editor header.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_image/

image_buttons.c

142 lines

Diff 32194

View Options

source/blender/editors/space_image/image_buttons.c

Rendering workspace: Slot, View Layer & Combined drop downs, displaying label before dataClosedPublicActions