Fix T67888: Incorrect Wireframe After Applying SubSurf/MultiRes
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 17 2020, 4:56 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Brecht Van Lommel (brecht)

Maniphest Tasks

T67888: Wireframe not updating after applying subsurf

Commits

rB7ed3ebbc6e1f: Fix T67888: Incorrect Wireframe After Applying SubSurf/MultiRes

Summary

Show control edges stores the control edges in the mesh which is
picked up by the draw manager. When applyng a subsurf (or multires) we
don't want that data present in the base mesh. Any rebuilding of the mesh
would overwrite the data anyway.

This patch introduces a new flag for applying modifiers
that can be checked to ignore storing display specific data in
the base mesh.

Diff Detail

Repository

rB Blender

Branch

T67888 (branched from master)

Build Status

Buildable 7196
Build 7196: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 17 2020, 4:56 PM

Harbormaster completed remote builds in B7195: Diff 22875.Mar 17 2020, 4:56 PM

Jeroen Bakker (jbakker) added a reviewer: Sybren A. Stüvel (sybren).Mar 17 2020, 4:56 PM

Jeroen Bakker (jbakker) added projects: Modifiers, GPU / Viewport.

updated comment

Harbormaster completed remote builds in B7196: Diff 22876.Mar 17 2020, 5:05 PM

Better would be to not add any hardcoded exceptions for this, but rather add a ModifierApplyFlag that is set in ModifierEvalContext, which each modifier type can handle as needed?

source/blender/editors/object/object_modifier.c
693–696	Multires has the same option so should be handled as well.
707–708	Applying can fail, we should be sure the modifier is not affected then.

This revision now requires changes to proceed.Mar 26 2020, 1:51 PM

Code review comments:

Add MOD_APPLY_TO_BASE_MESH that can be checked.
Add similar logic to multires

Harbormaster completed remote builds in B7307: Diff 23117.Mar 26 2020, 3:09 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Mar 26 2020, 3:10 PM

Jeroen Bakker (jbakker) retitled this revision from Fix T67888: Incorrect Wireframe After Applying SubSurf to Fix T67888: Incorrect Wireframe After Applying SubSurf/MultiRes.Mar 26 2020, 3:19 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 26 2020, 3:29 PM

This revision is now accepted and ready to land.Mar 26 2020, 3:29 PM

Closed by commit rB7ed3ebbc6e1f: Fix T67888: Incorrect Wireframe After Applying SubSurf/MultiRes (authored by Jeroen Bakker (jbakker)). · Explain WhyMar 26 2020, 3:35 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB7ed3ebbc6e1f: Fix T67888: Incorrect Wireframe After Applying SubSurf/MultiRes.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Mar 26 2020, 3:35 PM