Page MenuHome
Differential D7166

Fix T74837: GPencil: Mirror over first selected marker crashes
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 17 2020, 7:00 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T74837: GPencil: Mirror over first selected marker causing blender crash
Commits
rB1935cd4027ac: Fix T74837: GPencil: Mirror over first selected marker crashes
Summary

'mirror_gpf_marker()' needs a NULL bGPDframe for initialization [but
still requires a scene to get the marker].

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 17 2020, 7:00 PM
Harbormaster completed remote builds in B7199: Diff 22883.Mar 17 2020, 7:00 PM
Antonio Vazquez (antoniov) accepted this revision.Mar 18 2020, 1:11 PM
Antonio Vazquez (antoniov) added inline comments.
source/blender/editors/gpencil/editaction_gpencil.c
621

As you are changing the code, maybe change this line to (gpf != NULL)makes code esay to read and follow style guide.

This revision is now accepted and ready to land.Mar 18 2020, 1:11 PM
Closed by commit rB1935cd4027ac: Fix T74837: GPencil: Mirror over first selected marker crashes (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 18 2020, 8:52 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB1935cd4027ac: Fix T74837: GPencil: Mirror over first selected marker crashes.
Sybren A. Stüvel (sybren) awarded a token.Mar 19 2020, 11:57 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
8 lines

Diff 22920

View Options

source/blender/editors/gpencil/editaction_gpencil.c

Loading...