Silence clang warning about copying `GridBase::Ptr` in `volume.cc`
ClosedPublic
Actions

Authored by Stephan Seitz (theHamsta) on Mar 18 2020, 11:01 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rBda019efde9b1: Cleanup: silence warnign in volume grid code

Summary

Clang warned about a unnecessary copy of GridBase::Ptr (alias for std::shared_ptr<openvdb::GridBase>) without the &. This would not be dramatic but this PR silences the warning.

Diff Detail

Repository: rB Blender

Event Timeline

Stephan Seitz (theHamsta) created this revision.Mar 18 2020, 11:01 PM

Jacques Lucke (JacquesLucke) added a reviewer: Brecht Van Lommel (brecht).Mar 19 2020, 11:33 AM

btw, here is the warning:

../source/blender/blenkernel/intern/volume.cc:684:8: note: use reference type 'const openvdb::GridBase::Ptr &' (aka 'const shared_ptr<openvdb::v5_2::GridBase> &') to prevent copying
  for (const openvdb::GridBase::Ptr vdb_grid : vdb_grids) {

Brecht Van Lommel (brecht) accepted this revision.Mar 19 2020, 11:52 AM

This revision is now accepted and ready to land.Mar 19 2020, 11:52 AM

Closed by commit rBda019efde9b1: Cleanup: silence warnign in volume grid code (authored by Stephan <theHamsta>, committed by Brecht Van Lommel (brecht)). · Explain WhyMar 19 2020, 9:58 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBda019efde9b1: Cleanup: silence warnign in volume grid code.