Paths

Table of Contentst

Differential D7176

Fix T70807: Weight Paint Overlay XRay
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 19 2020, 11:15 AM.

Tags

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T70807: Vertex paint is not visible in X-Ray view

Commits

rB1ca1744c29e2: Fix T70807: Weight Paint Overlay XRay

Summary

Weight paint overlay was not working when XRay was turned on.

The Weight Paint overlay is rendered directly into the default
framebuffer with a depth equal test. This test fails as the depth won't match.
This patch will write also to the depth buffer.

Diff Detail

Repository

Branch

T70807 (branched from master)

Build Status

Buildable 7217
Build 7217: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 19 2020, 11:15 AM

Harbormaster completed remote builds in B7217: Diff 22934.Mar 19 2020, 11:15 AM

Jeroen Bakker (jbakker) retitled this revision from Fix T70807: Weight Paint Overlay XRay/In Front to [WIP] Fix T70807: Weight Paint Overlay XRay/In Front.Mar 19 2020, 11:16 AM

Jeroen Bakker (jbakker) added a project: GPU / Viewport.

Philipp Oeser (lichtwerk) mentioned this in D7179: Fix T74096: Paint Masking overlay can`t be hidden.Mar 19 2020, 11:37 AM

Used wrong DrawState in previous patch

Harbormaster completed remote builds in B7220: Diff 22938.Mar 19 2020, 11:46 AM

Jeroen Bakker (jbakker) retitled this revision from [WIP] Fix T70807: Weight Paint Overlay XRay/In Front to Fix T70807: Weight Paint Overlay XRay.Mar 19 2020, 11:54 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Merged with latest master

Harbormaster completed remote builds in B7264: Diff 23027.Mar 23 2020, 2:14 PM

I don't know if we should commit this quick fix or go for a more in depth fix.

This proposed fix have ordering issue of faces with transparency.
I would propose to draw the mesh depth before doing the transparent pass.

source/blender/draw/engines/overlay/overlay_paint.c
42	This is a bit more tricky, the object can be transparent even in solid mode because of material alpha or object alpha.

Clément Foucault (fclem) requested changes to this revision.Mar 23 2020, 9:36 PM

This revision now requires changes to proceed.Mar 23 2020, 9:36 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Mar 24 2020, 8:12 AM

In D7176#172525, @Clément Foucault (fclem) wrote:

I don't know if we should commit this quick fix or go for a more in depth fix.

I will go for the in depth fix.

Philipp Oeser (lichtwerk) mentioned this in rB579447bd892a: Fix T74096: Paint Masking overlay can`t be hidden.Mar 24 2020, 9:48 AM

added a more indepth check to identify the blending mode
rebased with master

Harbormaster completed remote builds in B7300: Diff 23103.Mar 26 2020, 8:58 AM

Moved the Wireframe mode check into paint_object_is_rendered_transparent

Harbormaster completed remote builds in B7301: Diff 23104.Mar 26 2020, 9:05 AM

Clément Foucault (fclem) accepted this revision.Mar 26 2020, 12:45 PM

Clément Foucault (fclem) added inline comments.

source/blender/draw/engines/overlay/overlay_paint.c
176	you can reuse the same batch from `DRW_cache_mesh_surface_weights_get` to avoid creating more batches.

This revision is now accepted and ready to land.Mar 26 2020, 12:45 PM

Closed by commit rB1ca1744c29e2: Fix T70807: Weight Paint Overlay XRay (authored by Jeroen Bakker (jbakker)). · Explain WhyMar 26 2020, 1:35 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB1ca1744c29e2: Fix T70807: Weight Paint Overlay XRay.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

overlay/

overlay_paint.c

7 lines

Diff 22934

source/blender/draw/engines/overlay/overlay_paint.c

Loading...