Fix T74096: Paint Masking overlay can`t be hidden
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 19 2020, 11:37 AM.

Details

Reviewers

Jeroen Bakker (jbakker)
Clément Foucault (fclem)

Maniphest Tasks

T74096: Texture paint. Masking overlay can`t be hidden (regression bug)

Commits

rB579447bd892a: Fix T74096: Paint Masking overlay can`t be hidden

Summary

Caused by rB9516921c05bd.

Dont really see a reason to draw overlays here if overlays are disabled.
Looks like this only affects Face/Vertex mask selection drawing [which
should indeed be hidden when overlays are disabled] next to two
exceptions:

OVERLAY_paint_vertex_cache_populate draws weights as well [D7176 /

T70807 might be related here, but to me it looks like drawing weights
here is actually not needed at all?]

OVERLAY_paint_texture_cache_populate calls

DRW_cache_mesh_surface_texpaint_get [not sure about this one, this is
also called from workbench_cache_texpaint_populate, is this needed here
when overlays are hidden?]

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 19 2020, 11:37 AM

Harbormaster completed remote builds in B7219: Diff 22937.Mar 19 2020, 11:37 AM

As an alternative, Face / Vertex mask could be disabled a bit more explicitly inside OVERLAY_paint_texture_cache_populate / OVERLAY_paint_vertex_cache_populate

Vyacheslav (hitrpr) awarded a token.Mar 19 2020, 10:03 PM

Clément Foucault (fclem) accepted this revision.Mar 23 2020, 6:20 PM

This revision is now accepted and ready to land.Mar 23 2020, 6:20 PM

Closed by commit rB579447bd892a: Fix T74096: Paint Masking overlay can`t be hidden (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 24 2020, 9:48 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB579447bd892a: Fix T74096: Paint Masking overlay can`t be hidden.