Differential D7184

Fix T74808: Division by 0 in Cloth brush solver with overlapping vertices
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Mar 19 2020, 7:15 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Maniphest Tasks

T74808: Sculpt mode: cloth brush breaking up mesh

Commits

rBc32cf06e42fc: Fix T74808: Division by 0 in Cloth brush solver with overlapping vertices

Summary

This checks that the distance of the current positions of two connected
vertices is not 0 before calculating the correction vectors for those
vertices.

Diff Detail

Repository

rB Blender

Branch

T74808 (branched from master)

Build Status

Buildable 7225
Build 7225: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Mar 19 2020, 7:15 PM

Harbormaster completed remote builds in B7225: Diff 22946.Mar 19 2020, 7:15 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Mar 19 2020, 7:16 PM

Jeroen Bakker (jbakker) accepted this revision.Mar 26 2020, 11:01 AM

This revision is now accepted and ready to land.Mar 26 2020, 11:01 AM

Closed by commit rBc32cf06e42fc: Fix T74808: Division by 0 in Cloth brush solver with overlapping vertices (authored by Pablo Dobarro (pablodp606)). · Explain WhyMar 26 2020, 3:38 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rBc32cf06e42fc: Fix T74808: Division by 0 in Cloth brush solver with overlapping vertices.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

sculpt_cloth.c

9 lines

Diff 22946

View Options

source/blender/editors/sculpt_paint/sculpt_cloth.c

Fix T74808: Division by 0 in Cloth brush solver with overlapping verticesClosedPublicActions