Differential D718

Adding split impulse option to the game engine
AbandonedPublic
Actions

Authored by Inês Almeida (brita_) on Aug 7 2014, 3:10 PM.

Details

Reviewers

Dalai Felinto (dfelinto)
Mitchell Stokes (moguri)

Maniphest Tasks

T32105: Unstable triangle mesh collision bounds

Summary

Reduces extra velocity on object penetration

Diff Detail

Event Timeline

Inês Almeida (brita_) updated this revision to Diff 2363.Aug 7 2014, 3:10 PM

Inês Almeida (brita_) retitled this revision from to Adding split impulse option to the game engine.

Inês Almeida (brita_) updated this object.

Inês Almeida (brita_) set the repository for this revision to rB Blender.

Inês Almeida (brita_) added projects: Game Physics, Game Engine.

Inês Almeida (brita_) added a task: T32105: Unstable triangle mesh collision bounds .

Inês Almeida (brita_) added a subscriber: Sergej Reich (sergof).

Is this supposed to be an option visible on the interface?

I think it is a good option to improve stability in certain cases. Additionally with the UseSplitImpulse option perhaps it should be necessary to add an editable splitImpulsePenetrationThreshold slider.

On other matters, this patch misses API doc edits in doc/python_api/rst/bge.constrains.rst and also the patch doesn't apply correctly. It is necessary to do branch/master update.

source/gameengine/Ketsji/KX_PyConstraintBinding.cpp
111	Should be "setUseSplitImpulse (bool splitimpulse)\n" instead of "gPySetUseSplitImpulsedoc\n".

Sergey Sharybin (sergey) added reviewers: Mitchell Stokes (moguri), Dalai Felinto (dfelinto).Feb 4 2015, 8:03 PM

Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).

Sergey Sharybin (sergey) added inline comments.

source/gameengine/Ketsji/KX_PyConstraintBinding.cpp
1	Tsk tsk ;)

Mitchell Stokes (moguri) added inline comments.Feb 4 2015, 10:58 PM

source/gameengine/Ketsji/KX_PyConstraintBinding.cpp
412	I think returning NULL without setting an error is an issue for Python.

BGE was removed in Blender 2.80 this patch is being closed as a result.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

properties_game.py

1 line

source/

blender/

makesdna/

DNA_world_types.h

1 line

makesrna/

intern/

5 lines

gameengine/

Converter/

KX_BlenderSceneConverter.cpp

2 lines

Ketsji/

KX_PyConstraintBinding.cpp

25 lines

Physics/

Bullet/

CcdPhysicsEnvironment.h

1 line

CcdPhysicsEnvironment.cpp

6 lines

common/

PHY_IPhysicsEnvironment.h

2 lines

Diff 2363

release/scripts/startup/bl_ui/properties_game.py

Loading...

source/blender/makesdna/DNA_world_types.h

Loading...

source/blender/makesrna/intern/rna_scene.c

Loading...

source/gameengine/Converter/KX_BlenderSceneConverter.cpp

Loading...

source/gameengine/Ketsji/KX_PyConstraintBinding.cpp

Loading...

source/gameengine/Physics/Bullet/CcdPhysicsEnvironment.h

Loading...

source/gameengine/Physics/Bullet/CcdPhysicsEnvironment.cpp

Loading...

source/gameengine/Physics/common/PHY_IPhysicsEnvironment.h

Loading...