Differential D7192

Fix T74957: Matcap flip not updating
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 20 2020, 10:59 AM.

Tags

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)
Jeroen Bakker (jbakker)

Maniphest Tasks

T74957: Matcap flip function does not work in 2.83

Commits

rBa6dd22d4311c: Fix T74957: Matcap flip not updating

Summary

Caused by rBc476c36e4008.

This hooks into the existing FIXME (workaround for a missing update
tagging from operators), needs to also check the shading.flag (to detect
changes in V3D_SHADING_MATCAP_FLIP_X).

While this fix works, we have a couple of related reports, namely T74872,
T74744 where the NS_VIEW3D_SHADING notifier is not working reliably. Not
sure if there is a more general fix?

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 20 2020, 10:59 AM

Harbormaster completed remote builds in B7235: Diff 22968.Mar 20 2020, 10:59 AM

Philipp Oeser (lichtwerk) added a project: GPU / Viewport.Mar 20 2020, 11:00 AM

Philipp Oeser (lichtwerk) added a task: T74957: Matcap flip function does not work in 2.83.Mar 20 2020, 11:25 AM

Clément Foucault (fclem) accepted this revision.Mar 23 2020, 6:52 PM

This revision is now accepted and ready to land.Mar 23 2020, 6:52 PM

Closed by commit rBa6dd22d4311c: Fix T74957: Matcap flip not updating (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 24 2020, 9:52 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBa6dd22d4311c: Fix T74957: Matcap flip not updating.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

workbench/

workbench_data.c

6 lines

Diff 23049

source/blender/draw/engines/workbench/workbench_data.c

Loading...