Differential D7193

Fix T74872: Clipping Region not updating
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 20 2020, 11:42 AM.

Tags

None

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)
Jeroen Bakker (jbakker)

Maniphest Tasks

T74872: Clipping Region delay

Commits

rBed44bb902d6b: Fix T74872: Clipping Region not updating

Summary

Caused by rBc476c36e4008.

This hooks into the existing FIXME (workaround for a missing update
tagging), needs to also check the clip_state (to detect
changes in DRW_STATE_CLIP_PLANES).

While this fix works, we have a couple of related reports, namely T74957,
T74744 where the NS_VIEW3D_SHADING notifier is not working reliably. Not
sure if there is a more general fix?

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 20 2020, 11:42 AM

Harbormaster completed remote builds in B7236: Diff 22969.Mar 20 2020, 11:42 AM

Clément Foucault (fclem) requested changes to this revision.Mar 23 2020, 6:52 PM

Clément Foucault (fclem) added inline comments.

source/blender/draw/engines/workbench/workbench_data.c
192–200	remove this line then.

This revision now requires changes to proceed.Mar 23 2020, 6:52 PM

remove duplicate line

Harbormaster completed remote builds in B7270: Diff 23040.Mar 23 2020, 9:32 PM

Philipp Oeser (lichtwerk) marked an inline comment as done.Mar 23 2020, 9:33 PM

Clément Foucault (fclem) accepted this revision.Mar 23 2020, 9:35 PM

This revision is now accepted and ready to land.Mar 23 2020, 9:35 PM

Closed by commit rBed44bb902d6b: Fix T74872: Clipping Region not updating (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 24 2020, 9:56 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBed44bb902d6b: Fix T74872: Clipping Region not updating.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

workbench/

workbench_data.c

10 lines

Diff 23050

source/blender/draw/engines/workbench/workbench_data.c

Loading...