Paths

Table of Contentst

Differential D7194

Fix T74744: Studio Lights editor not updating in realtime when tweaking the settings
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 20 2020, 1:08 PM.

Tags

None

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)
Jeroen Bakker (jbakker)

Maniphest Tasks

T74744: Studio Lights editor not updating in realtime when tweaking the settings

Commits

rB02f7a6b2bdea: Fix T74744: Studio Lights editor not updating in realtime when tweaking the…

Summary

Caused by rBc476c36e4008.

This hooks into the existing FIXME (workaround for a missing update
tagging), reactivates the NS_VIEW3D_GPU notifier (introduced in
rB2ad3d8f158d2 -- but not going anywhere atm.) to check changes to rv3d-

rflag which indicated UserStudioLight has changed. To not have updates

all the time, the rflag also needs to be cleared again (see original
rB2ad3d8f158d2), this is now done in 'workbench_draw_finish'.

While this fix works, we have a couple of related reports, namely T74957,
T74872 where the notifiers are not working reliably. Not sure if there is
a more general fix?

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 20 2020, 1:08 PM

Harbormaster completed remote builds in B7237: Diff 22970.Mar 20 2020, 1:09 PM

Clément Foucault (fclem) requested changes to this revision.Mar 23 2020, 6:51 PM

Clément Foucault (fclem) added inline comments.

source/blender/draw/engines/workbench/workbench_data.c
214	Put the `rv3d->rflag &= ~RV3D_GPULIGHT_UPDATE;` here.

This revision now requires changes to proceed.Mar 23 2020, 6:51 PM

clear rflag earlier

Harbormaster completed remote builds in B7271: Diff 23042.Mar 23 2020, 9:38 PM

Philipp Oeser (lichtwerk) marked an inline comment as done.Mar 23 2020, 9:39 PM

Clément Foucault (fclem) accepted this revision.Mar 23 2020, 9:47 PM

This revision is now accepted and ready to land.Mar 23 2020, 9:47 PM

Clément Foucault (fclem) requested changes to this revision.Mar 23 2020, 9:47 PM

Clément Foucault (fclem) added inline comments.

source/blender/draw/engines/workbench/workbench_data.c
213	check if rv3d is valid before doing so.

This revision now requires changes to proceed.Mar 23 2020, 9:47 PM

check if rv3d is valid

Harbormaster completed remote builds in B7272: Diff 23043.Mar 23 2020, 10:32 PM

Clément Foucault (fclem) accepted this revision.Mar 23 2020, 11:11 PM

This revision is now accepted and ready to land.Mar 23 2020, 11:11 PM

Closed by commit rB02f7a6b2bdea: Fix T74744: Studio Lights editor not updating in realtime when tweaking the… (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 24 2020, 10:00 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB02f7a6b2bdea: Fix T74744: Studio Lights editor not updating in realtime when tweaking the….

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

workbench/

workbench_data.c

8 lines

Diff 23051

source/blender/draw/engines/workbench/workbench_data.c

Loading...