Add missing keys for (ABNT) Brazilian keyboards
Changes PlannedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Mar 21 2020, 5:45 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Summary

Patch for Windows OS only

After so many reports about missing keys (T74968, T68577, T66607, T64004, T61359, T51714)
I decided to take a closer look at what may be happening and realized
that on the Brazilian keyboard 2 keys are missing.

This indicates that for some countries, there are some specific keys
that are not captured in the event.

This patch adds only the the Brazilian keyboard missing keys.
As I don't have a German or Swiss keyboard, it is difficult to identify
the other keys that may be missing.

I was also unable to test on Linux or Mac.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 7251
Build 7251: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Mar 21 2020, 5:45 AM

Harbormaster completed remote builds in B7251: Diff 22990.Mar 21 2020, 5:45 AM

You don't really need special keyboard, just add keyboard layout you want to test. I think, that I have used on screen keyboard to confirm these reports.

I was looking for some resources on keycodes produced by various layouts, but I haven't really found anything useful. Fact, that on Linux / MAC this may be completely different is quite sad as well...

Wilsimar (wilBr) awarded a token.Mar 23 2020, 5:11 PM

The problem is that most keyboards do not have enough keys to test. So you can't test non-existent keys.
I tried to use the virtual keyboard, but I had this problem with lack of keys when testing the Brazilian layout.

Germano Cavalcante (mano-wii) mentioned this in D7229: Fix missing text input on Windows with certain keyboard layouts.Mar 24 2020, 7:57 PM

I think adding more keys like this is fine in general.

But is there a place where we can find a list of all the ones we need to support? Can we copy it from e.g. Qt source code or another UI toolkit?

And can we do this for all platforms at the same time, or at least leave a TODO comment in the platforms that don't support it yet so it's clear there is something missing to be added?

This revision now requires changes to proceed.Mar 26 2020, 1:24 PM

To support this on multiple platforms I would have to edit my setup to work with Linux and Mac.
So I will postpone this patch for now.