Details

Reviewers

Commits

rBeb4e3bbe68c8: Simulations: Add new simulation data block

Summary

This introduces a new id data block with type ID_SIM.

The RNA part of this change is disabled by default for now.
The corresponding cmake option is WITH_SIMULATION_DATA_BLOCK_RNA.

The new data block does not yet have an embedded node tree.
I want to add that separately.

This is part of T73324.

The set of files I changed is based on rBb0a1cf2c9ae696.
However, I had to change fewer files, because I did not add a new object type.

Diff Detail

Repository

rB Blender

Branch

simulation-data-block (branched from master)

Build Status

Buildable 7285
Build 7285: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 24 2020, 2:59 PM

Harbormaster completed remote builds in B7279: Diff 23059.Mar 24 2020, 3:00 PM

Looks fine overall.

CMakeLists.txt
327	I would recommend naming this `WITH_NEW_SIMULATION_TYPE`, in case it needs to be checked in more places than RNA later.
source/blender/blenkernel/intern/lib_remap.c
526 ↗	(On Diff #23059)	Not needed here, this is not used as object data.
source/blender/editors/animation/anim_channels_defines.c
3053	VO -> SIM

This revision now requires changes to proceed.Mar 24 2020, 4:14 PM

rename WITH_SIMULATION_DATA_BLOCK_RNA to WITH_NEW_SIMULATION_TYPE
remove unnecessary case in lib_remap.c
replace VO_DS_EXPAND with SIM_DS_EXPAND

Harbormaster completed remote builds in B7285: Diff 23068.Mar 24 2020, 4:31 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 24 2020, 5:06 PM

This revision is now accepted and ready to land.Mar 24 2020, 5:06 PM

Jacques Lucke (JacquesLucke) added a child revision: D7287: Add simulation node tree type.Mar 31 2020, 12:29 PM

Update for latest master

Harbormaster completed remote builds in B7475: Diff 23466.Apr 6 2020, 11:52 AM

Merge branch 'master' into simulation-data-block

Harbormaster completed remote builds in B7512: Diff 23582.Apr 9 2020, 11:28 AM

Closed by commit rBeb4e3bbe68c8: Simulations: Add new simulation data block (authored by Jacques Lucke (JacquesLucke)). · Explain WhyApr 20 2020, 10:48 AM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBeb4e3bbe68c8: Simulations: Add new simulation data block.

For the records, I would not mind being reviewer next time you add a new data-block… Nothing critical here, but there were some changes needed re ID management, please see notes below.

source/blender/blenkernel/intern/simulation.cc
53–63	No need to define those when default behavior is fine, just set relevant pointers to NULL in the IDType struct...
68	This is handled by generic code, do not call that here. Means that function is also useless and can be removed too.
source/blender/editors/interface/interface_templates.c
685	Browse, not Browser

@Bastien Montagne (mont29) sorry for not adding you. Will fix those issues in master.

Jacques Lucke (JacquesLucke) mentioned this in rB8d53e59e32a3: Cleanup: Remove unnecessary callbacks where default behavior is fine.Apr 20 2020, 11:25 AM

Iliya Katueshenock (Moder) added a subscriber: Iliya Katueshenock (Moder).Dec 7 2022, 11:37 PM

Add new simulation data blockClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23068

CMakeLists.txt

source/blender/blenkernel/BKE_idtype.h

source/blender/blenkernel/BKE_main.h

source/blender/blenkernel/BKE_simulation.h

source/blender/blenkernel/CMakeLists.txt

source/blender/blenkernel/intern/anim_sys.c

source/blender/blenkernel/intern/idtype.c

source/blender/blenkernel/intern/lib_query.c

source/blender/blenkernel/intern/main.c

source/blender/blenkernel/intern/simulation.cc

source/blender/blenloader/intern/readfile.c

source/blender/blenloader/intern/writefile.c

source/blender/blentranslation/BLT_translation.h

source/blender/depsgraph/intern/builder/deg_builder_nodes.h

source/blender/depsgraph/intern/builder/deg_builder_nodes.cc

source/blender/depsgraph/intern/builder/deg_builder_relations.h

source/blender/depsgraph/intern/builder/deg_builder_relations.cc

source/blender/editors/animation/anim_channels_defines.c

source/blender/editors/animation/anim_channels_edit.c

source/blender/editors/animation/anim_filter.c

source/blender/editors/include/ED_anim_api.h

source/blender/editors/interface/interface_icons.c

source/blender/editors/interface/interface_templates.c

source/blender/editors/render/render_opengl.c

source/blender/editors/space_nla/nla_buttons.c

source/blender/editors/space_nla/nla_channels.c

source/blender/editors/space_outliner/outliner_draw.c

source/blender/editors/space_outliner/outliner_intern.h

source/blender/editors/space_outliner/outliner_tools.c

source/blender/editors/space_outliner/outliner_tree.c

source/blender/makesdna/DNA_ID.h

source/blender/makesdna/DNA_simulation_defaults.h

source/blender/makesdna/DNA_simulation_types.h

source/blender/makesdna/intern/CMakeLists.txt

source/blender/makesdna/intern/dna_defaults.c

source/blender/makesdna/intern/makesdna.c

source/blender/makesrna/RNA_access.h

source/blender/makesrna/intern/CMakeLists.txt

source/blender/makesrna/intern/makesrna.c

source/blender/makesrna/intern/rna_ID.c

source/blender/makesrna/intern/rna_internal.h

source/blender/makesrna/intern/rna_main.c

source/blender/makesrna/intern/rna_main_api.c

source/blender/makesrna/intern/rna_simulation.c

source/blender/makesrna/intern/rna_space.c

Add new simulation data block
ClosedPublic
Actions

Revision Contents
Changeset List