This revision fixes a bug with the lib folder creation. As Moguri stated in his add-on wiki, when downloading blender packages for different operating systems, you unpack them in the lib folder (assuming the folder was already created) and press the auto add platform button. Only problem is that when auto-downloading the packages from http://download.blender.org/release/ with the add-on, the lib folder is not created automatically for a new user.
Details
Details
- Reviewers
Mitchell Stokes (moguri) - Group Reviewers
Game Engine - Commits
- rBA6d145221a1ec: Game Engine Publishing | Lib folder creation bug
Diff Detail
Diff Detail
- Repository
- rBA Blender Add-ons
- Branch
- D723
Event Timeline
Comment Actions
The changes to PublishDownloadPlatforms are good, but I don't like the idea of PublishAutoPlatforms creating a folder. If it is creating a folder, that means there are no platforms to add, which could be a silent error (typo in the lib path causing no platforms to be found). Instead, I would prefer to report to the user that the lib path does not exist and to cancel the operator (return {'CANCELLED'}).
Comment Actions
Changed class "PublishAutoPlatforms" to return an error if the lib folder does not exist.
Comment Actions
Looks good. One minor tweak for clarity: the error should be "Could not add platforms, lib folder (%s) does not exist"
For tooltips, we don't use ending periods, but I'm not sure how this applies to error reports. My guess would be to leave them out there too.
Comment Actions
Please update your remaining patches to remove the author line. It causes a trivial conflict, but I cannot seem to get Arcanist to nicely merge it (it just bombs out).