Page MenuHome
Differential D7240

Add basic project files
ClosedPublic
Actions

Authored by Sem Mulder (SemMulder) on Mar 26 2020, 3:25 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)

Diff Detail

Repository
rL Looper
Branch
review2/01/project_files_fixes
Build Status
Buildable 7334
Build 7334: arc lint + arc unit

Event Timeline

Sem Mulder (SemMulder) created this revision.Mar 26 2020, 3:25 PM
Harbormaster completed remote builds in B7308: Diff 23118.Mar 26 2020, 3:25 PM
Sybren A. Stüvel (sybren) requested changes to this revision.Mar 27 2020, 9:58 AM
Sybren A. Stüvel (sybren) added inline comments.
pyproject.toml
13

Last time I checked the code wasn't compatible with Python 3.6 and required 3.7. Has this been fixed now and is it compatible with 3.6 again? Or should this be 3.7?

24

Is there a specific release we need, so that we want to have the prerelease now already? Or is this to work around some non-semver versioning scheme? This should be documented.

This revision now requires changes to proceed.Mar 27 2020, 9:58 AM
Sem Mulder (SemMulder) marked an inline comment as done.Mar 27 2020, 10:04 AM
Sem Mulder (SemMulder) added inline comments.
pyproject.toml
13

This has been fixed and the code has been tested against 3.6, 3.7 and 3.8.

24

The whole black project is in prerelease mode. That is, there is no non-prerelease version. I'll ad a comment.

Sem Mulder (SemMulder) updated this revision to Diff 23180.Mar 27 2020, 10:10 AM
Sem Mulder (SemMulder) marked an inline comment as done.
  • Add comment explaining why we need prereleases for Black
Harbormaster completed remote builds in B7334: Diff 23180.Mar 27 2020, 10:10 AM
Sem Mulder (SemMulder) marked an inline comment as done.Mar 27 2020, 10:10 AM
Sybren A. Stüvel (sybren) accepted this revision.Mar 27 2020, 11:45 AM
This revision is now accepted and ready to land.Mar 27 2020, 11:45 AM
Sem Mulder (SemMulder) updated this revision to Diff 23192.Mar 27 2020, 3:21 PM

Revert the lookup of the PaymentMethod on the Customer

Harbormaster completed remote builds in B7339: Diff 23192.Mar 27 2020, 3:21 PM
Francesco Siddi (fsiddi) mentioned this in D7445: Looper feature parity with the Development Fund implementation.Apr 16 2020, 12:21 AM
Francesco Siddi (fsiddi) mentioned this in rLa7fa307c83e2: Add comment about "black" package.Jun 7 2020, 10:59 PM
Sybren A. Stüvel (sybren) closed this revision.Jul 21 2020, 3:02 PM

Closing this as Sem is no longer working at Blender HQ and AFAIK the interesting portions of this patch have been committed by now.

Revision Contents
Changeset List

PathSize
674 lines
5 lines
202 lines
4 lines

Diff 23180

View Options

LICENSE

Loading...
View Options

manage.sh

Loading...
View Options

poetry.lock

Loading...
View Options

pyproject.toml

Loading...