Differential D7249

Fix T75104: Update Face Sets visibility when entering Sculpt Mode
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Mar 26 2020, 8:23 PM.

Tags

Subscribers

None

Details

Reviewers

Jeroen Bakker (jbakker)

Maniphest Tasks

T75104: Sculpt Mode: Combined mesh doesn't show in sculpt mode

Commits

rBbf49bb354fca: Fix T75104: Update Face Sets visibility when entering Sculpt Mode

Summary

Geometry that was just added to sculpt mode has the SCULPT_FACE_SET_NONE
assigned, so it was hidden by default. By doing this when entering
sculpt mode a new visible face set is created for it, making it easier
to isolate it again if you want to do further tweaking with the sculpt
tools.

Also, this also fixes the issue that may happen when changing the mesh
visibility in edit mode. Now visibility changes done outside sculpt mode
are stored in the face sets when entering sculpt mode, so mesh
visibility should stay the same.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Mar 26 2020, 8:23 PM

Harbormaster completed remote builds in B7328: Diff 23163.Mar 26 2020, 8:23 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Mar 26 2020, 8:24 PM

Jeroen Bakker (jbakker) requested changes to this revision.Apr 2 2020, 10:20 AM

Jeroen Bakker (jbakker) added inline comments.

source/blender/editors/sculpt_paint/sculpt.c
7489	Wouldn't this also update all other facesets that were still 0? If not, please explain in the comment.

This revision now requires changes to proceed.Apr 2 2020, 10:20 AM

Review update

Harbormaster completed remote builds in B7417: Diff 23368.Apr 2 2020, 3:59 PM

Pablo Dobarro (pablodp606) added a project: BF Blender (2.83).Apr 8 2020, 12:45 PM

Jeroen Bakker (jbakker) accepted this revision.Apr 14 2020, 3:52 PM

This revision is now accepted and ready to land.Apr 14 2020, 3:52 PM

Closed by commit rBbf49bb354fca: Fix T75104: Update Face Sets visibility when entering Sculpt Mode (authored by Pablo Dobarro (pablodp606)). · Explain WhyApr 14 2020, 7:28 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rBbf49bb354fca: Fix T75104: Update Face Sets visibility when entering Sculpt Mode.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

22 lines

Diff 23739

source/blender/editors/sculpt_paint/sculpt.c

Loading...