Page MenuHome
Differential D7251

Fix T75111: Crash when using subframes for animated fluid collider
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 27 2020, 12:05 PM.

Details

Reviewers
Sebastián Barschkis (sebbas)
Maniphest Tasks
T75111: Crash | Mataflow Liquid Sim | when using Obstacle with Armature and Sampling Substeps > 0
Commits
rB5ce41e6f5706: Fix T75111: Crash when using subframes for animated fluid collider
Summary

This is not dependent on having an armature as mentioned in T75111.
The collider simply has to be animated.

Diff Detail

Repository
rB Blender
Branch
moving-collider-subframes (branched from master)
Build Status
Buildable 7335
Build 7335: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 27 2020, 12:05 PM
Harbormaster completed remote builds in B7335: Diff 23183.Mar 27 2020, 12:05 PM
Jacques Lucke (JacquesLucke) added a task: T75111: Crash | Mataflow Liquid Sim | when using Obstacle with Armature and Sampling Substeps > 0.Mar 27 2020, 12:05 PM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/intern/fluid.c
776

@Sebastián Barschkis (sebbas), should the same "fix" be applied to distances? Could this be necessary at some point?

Sebastián Barschkis (sebbas) accepted this revision.Mar 27 2020, 12:18 PM
Sebastián Barschkis (sebbas) added inline comments.
source/blender/blenkernel/intern/fluid.c
776

@Jacques Lucke (JacquesLucke) I think the check for incluence is sufficient. influence is only used for smoke and therefore needs the check. distances is used for smoke and liquid. It should always exist.

This revision is now accepted and ready to land.Mar 27 2020, 12:18 PM
Closed by commit rB5ce41e6f5706: Fix T75111: Crash when using subframes for animated fluid collider (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMar 27 2020, 12:33 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB5ce41e6f5706: Fix T75111: Crash when using subframes for animated fluid collider.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
18 lines

Diff 23183

View Options

source/blender/blenkernel/intern/fluid.c

Loading...