Paths

Table of Contentst

Differential D7254

Fix T75121: Memory leak in Surface Smooth
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Mar 27 2020, 1:53 PM.

Tags

None

Subscribers

None

Details

Reviewers

Jeroen Bakker (jbakker)

Maniphest Tasks

T75121: High RAM usage by Surface smooth brush.

Commits

rB6cc4c68dad79: Fix T75121: Memory leak in Surface Smooth

Summary

The brush was allocating new memory for storing the displacemnets at the
beginning of each stroke step and not freeing them.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Mar 27 2020, 1:53 PM

Harbormaster completed remote builds in B7337: Diff 23188.Mar 27 2020, 1:53 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Mar 27 2020, 1:53 PM

Jeroen Bakker (jbakker) requested changes to this revision.Mar 27 2020, 2:40 PM

Jeroen Bakker (jbakker) added inline comments.

source/blender/editors/sculpt_paint/sculpt.c
3464	Would it be good to add BLI_assert statements here to see if the buffers are NULL? If we do this with all allocations here it would lead to detecting these issues during development/testing.
6868	Best to use `MEM_SAFE_FREE`

This revision now requires changes to proceed.Mar 27 2020, 2:40 PM

Review Update

Harbormaster completed remote builds in B7338: Diff 23190.Mar 27 2020, 2:50 PM

Jeroen Bakker (jbakker) accepted this revision.Apr 2 2020, 8:45 AM

This revision is now accepted and ready to land.Apr 2 2020, 8:45 AM

Closed by commit rB6cc4c68dad79: Fix T75121: Memory leak in Surface Smooth (authored by Pablo Dobarro (pablodp606)). · Explain WhyApr 2 2020, 3:36 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB6cc4c68dad79: Fix T75121: Memory leak in Surface Smooth.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

10 lines

Diff 23366

source/blender/editors/sculpt_paint/sculpt.c

Loading...