Page MenuHome
Differential D7256

Fluids: improve subframe handling
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 27 2020, 5:22 PM.

Details

Reviewers
Sebastián Barschkis (sebbas)
Commits
rB1c3ded12f439: Fluids: improve subframe handling
Summary

Before:

After:

The example file is a slightly modified version from T74062.

Mantaflow_AdaptiveTimeSteps_modified.blend682 KBDownload

First first frame is still baked incorrectly, but that is a separate issue. It seems wrong to me that any simulation happens at all in the first frame.

As for T74062, I feel like there is confusion about what adaptive time steps is doing. If I understand it correctly, this setting only has an impact of the fluid itself is moving fast, but not if the emitter is moving fast. Maybe you should clarify that (in a tooltip) and in the thread.

Diff Detail

Repository
rB Blender
Branch
subframe-smoke-emission (branched from master)
Build Status
Buildable 7412
Build 7412: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 27 2020, 5:22 PM
Harbormaster completed remote builds in B7344: Diff 23201.Mar 27 2020, 5:22 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Mar 27 2020, 5:27 PM
Jacques Lucke (JacquesLucke) added a reviewer: Sebastián Barschkis (sebbas).
Ted Nielsen (brilliant_ape) awarded a token.Mar 27 2020, 5:38 PM
zebus3d (ofuscado) awarded a token.Mar 30 2020, 9:14 AM
Sebastián Barschkis (sebbas) requested changes to this revision.Apr 1 2020, 5:26 PM

Can you expand this patch so that the subframe loop from update_obstacles() gets this update too?

This revision now requires changes to proceed.Apr 1 2020, 5:26 PM
Jacques Lucke (JacquesLucke) updated this revision to Diff 23358.EditedApr 2 2020, 10:09 AM
  • fix subframe handling for obstacles

Before subframes didn't work at all in this example.

Now, with one subframe (no adaptive time steps):

With two subframes (no adaptive time steps):

With 50 subframes (no adaptive time steps):

With 10 time steps:

It all seems to behave as I'd expect.

obstacle_subframe.blend569 KBDownload

Harbormaster completed remote builds in B7412: Diff 23358.Apr 2 2020, 10:09 AM
Sebastián Barschkis (sebbas) accepted this revision.Apr 2 2020, 10:30 AM
This revision is now accepted and ready to land.Apr 2 2020, 10:30 AM
Closed by commit rB1c3ded12f439: Fluids: improve subframe handling (authored by Jacques Lucke (JacquesLucke)). · Explain WhyApr 2 2020, 10:37 AM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB1c3ded12f439: Fluids: improve subframe handling.
Jacques Lucke (JacquesLucke) mentioned this in T74062: Mantaflow Gas domain: 'use adaptive time steps' doesn't seem to adapt..Apr 2 2020, 11:26 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
73 lines

Diff 23358

View Options

source/blender/blenkernel/intern/fluid.c

Loading...